Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Resolve circular reference #155

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

4513ECHO
Copy link
Contributor

@4513ECHO 4513ECHO commented Aug 28, 2024

  • Stop re-exporting Base* classes in types.ts
  • Unify Base*Params types to BaseParams
  • Remove loader property from arguments of methods of BaseSource
  • Split ContextBuilder type definition and implemention

Dependencies Graph:

image

Size reduction:

$ deno info jsr:@shougo/ddc-vim@6.0.1/types | head -5
local: /Users/user/Library/Caches/deno/deps/https/jsr.io/a590a33b9a7e50e59f7ff1b4f3d8c9586c79b6750e94952894e3cc43c1d70844
emit: /Users/user/Library/Caches/deno/gen/https/jsr.io/a590a33b9a7e50e59f7ff1b4f3d8c9586c79b6750e94952894e3cc43c1d70844.js
type: TypeScript
dependencies: 292 unique
size: 1.93MB
$ deno info denops/ddc/types.ts | head -5
local: /Users/user/Library/Develops/github.com/4513ECHO/ddc.vim/denops/ddc/types.ts
type: TypeScript
dependencies: 10 unique
size: 26.5KB

- Stop re-exporting Base* classes in types.ts
- Unify Base*Params types to BaseParams
- Remove loader property from arguments of methods of BaseSource
@Shougo
Copy link
Owner

Shougo commented Aug 29, 2024

LGTM. Why it is WIP?

@4513ECHO 4513ECHO marked this pull request as ready for review August 29, 2024 14:48
@Shougo
Copy link
Owner

Shougo commented Aug 30, 2024

OK. I will merge it later.

@Shougo Shougo merged commit 3b9c29a into Shougo:main Aug 30, 2024
2 checks passed
@Shougo
Copy link
Owner

Shougo commented Aug 30, 2024

Merged.

@4513ECHO 4513ECHO deleted the resolve_circular_reference branch August 31, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants