fix: Fix incorrect party during Investigation power #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ac75a16): https://secret-hitler-online--pr85-fix-investigation-pa-ugrjdryc.web.app (expires Sat, 07 Oct 2023 04:42:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1ff8fffee68997d863205853d16b55705cc85efb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84, "President [Investigation] shows wrong loyalty".
This was caused by a bad assumption on the original Investigation prompt card, which assumed it had access to all player roles (which is untrue as of the most recent update). I've changed it so that the prompt gets its data from a packet sent by the server instead, which I think was what it was originally supposed to do.
I've tested this change locally and can confirm that I get the correct role as both Liberal and Fascist players.