Extend API for directives and attributes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements many DirectiveNode creation methods, and introduces node transform functions and custom vue-sfcmod metadata on Nodes, so that ForNodes are easier to work with. ForNodes now have a distinct element for end users to work with, regardless of whether generated or built by the compiler.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 78.45% 81.07% +2.62%
==========================================
Files 20 22 +2
Lines 1467 1982 +515
Branches 163 229 +66
==========================================
+ Hits 1151 1607 +456
- Misses 313 371 +58
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch extends API support for creating and search directives and attributes. As part of that work, ForNode/ForDirective was heavily normalised through compiler transforms, leading to an AST now distinct from that produced by Vue 3's SFC compiler.
Work to do: