New Lines in Messages #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. These make good sense. I will make these changes after the upcoming fast follow-up bug fix release for version 2.3.1 which we hope to happen in a week or so. If we add them now, that will necessitate changes to translations that would delay the release while we wait for volunteers to handle them. |
|
BeckyEbook, there are conflicts with the late changes I made to improve missing NCX handling in ImportEPUB.cpp and this PR. Would you please rebase your message changes from this PR on the released 2.3.1 source, so I can merge it without any conflicts. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
\ncharacter did not create a new line in the messages, I added<br>in three places. This works well.Below is the before and after view.
Message One:
Message Two:
Message Three:
