Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird behavior with SigmaRegularExpression.escape(escape_escape_char=False) #153

Closed
Res260 opened this issue Oct 31, 2023 · 3 comments · Fixed by #154
Closed

Weird behavior with SigmaRegularExpression.escape(escape_escape_char=False) #153

Res260 opened this issue Oct 31, 2023 · 3 comments · Fixed by #154

Comments

@Res260
Copy link
Contributor

Res260 commented Oct 31, 2023

Reading the docstring of SigmaRegularExpression.escape(),I don't think this is an intended behavior?

image

I'm not sure why it does that, but if I get confirmation that this is unexpected behavior, I can look for a fix :)
Res260 pushed a commit to Res260/pySigma that referenced this issue Oct 31, 2023
Fix a bug where SigmaRegularExpression.escape() was buggy when using …
434c13f 
…param escape_escape_char=False. Fixes SigmaHQ#153
@Res260 Res260 mentioned this issue Oct 31, 2023
Merged
@Res260
Copy link
Contributor Author

Res260 commented Oct 31, 2023

Fix was pretty simple, see #154

@Res260
Copy link
Contributor Author

Res260 commented Nov 14, 2023

Hello @thomaspatzke , would it be possible to create a new version of pysigma with this bugfix? We're waiting on a new version to fix the bug in our backend :)

@thomaspatzke
Copy link
Member

Sure, done! v0.10.7 is waiting for you 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug where SigmaRegularExpression.escape() was buggy when using … Res260/pySigma
2 participants
@thomaspatzke @Res260