Distinct condition state #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When state objects are shared between conversions of conditions, DeferredQueryExpressions were being reused across all generated queries. To prevent this, initialise a distinct state object per condition that is used during the subsequent finalisation step.
Otherwise the ConversionState will share the same underlying processing_state.
|
Great! Thanks a lot for the PR! |
kelnage
added a commit
to grafana/pySigma-backend-loki
that referenced
this pull request
Oct 19, 2023
Applies fixes from SigmaHQ/pySigma#127 to fix the issue that a list of conditions would all share the same state.
kelnage
added a commit
to grafana/pySigma-backend-loki
that referenced
this pull request
Oct 20, 2023
Applies fixes from SigmaHQ/pySigma#127 to resolve the issue that a list of conditions in a single rule would all share the same state. Closes: #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #126, a single
ConversionStateobject was being shared between conversions when multipleconditions were present, which meant anyDeferredQueryExpressions generated when converting thoseconditions were duplicated across all generated queries.This commit creates a separate
ConversionStateobject for eachcondition, and includes a unit test to demonstrate that it fixes #126. This change also means the conversion of eachconditionwill also have its own distinctprocessing_state; I made that decision as I was unable to envisage a situation where a sharedprocessing_statebetween conditions would be appropriate.