Apply backend naming convention #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafa
changed the title
mostafa
changed the title
|
Argh, sorry, I've made a mistake...forgot about it in our discussion that name already exists as descriptive name like here. These usually contain spaces and are long, what is painful for CLI usage. I think it's easier for backwards compatibility to use another class variable name identifier for this purpose. Can you change this? Can you further add a test for the backend name generation? Anyways...great contribution, I've already removed it from my todo list 😁 |
Show a warning when a duplicate backend name (unnamed backend) is found
mostafa
force-pushed
the
apply-backend-naming-convention
branch
from
fd9a269
to
ba586ad
Compare
mostafa
commented
Jul 10, 2023
mostafa
commented
Jul 10, 2023
|
Great, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #110: #110 (comment)