Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add em dash, en dash and horizontal bar to windash modifier #233

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

martinspielmann
Copy link
Contributor

@martinspielmann martinspielmann commented Jun 27, 2024

The existing windash modifier takes into account that many Windows programs accept their arguments provided via / and -.

However, multiple programs including Powershell additionally support – (en dash), — (em dash), and ― (horizontal bar). E.g. see the Powershell Tokenizer that handles all dashes the same way:
image

Downside:

  • More search parameters and complexity: Every windash expanded argument string will result in five (5) search parameters instead of only two (2). This multiplies when there is more than one arguments processed by windash. See tests/test_modifiers.py

Advantage:

  • Detection of simple command-line obfuscation relying on hiding command-line arguments.

References

@thomaspatzke
Copy link
Member

Great, thanks for the PR!

@thomaspatzke thomaspatzke merged commit 2c4ef60 into SigmaHQ:main Jun 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants