Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some update to the validators #250

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Some update to the validators #250

merged 4 commits into from
Aug 10, 2024

Conversation

frack113
Copy link
Member

@frack113 frack113 commented Aug 6, 2024

  • Add **kargs to SigmaRuleValidator validate
  • Rework Pattern Tag validator like the tlp

nasbench
nasbench approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@nasbench nasbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frack113 and others added 2 commits August 9, 2024 19:50
@frack113
corrects grammar
071b5d0
@thomaspatzke
Validator parameter configuration
72983c2 
Moved validator check arguments to class construction.
thomaspatzke
thomaspatzke approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@thomaspatzke thomaspatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved paramterization to validation class constructor and changed paramterized classes into frozen dataclasses.

@thomaspatzke thomaspatzke merged commit f7252a5 into SigmaHQ:main Aug 10, 2024
12 checks passed
@frack113 frack113 deleted the kargs_V2 branch August 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshnck joshnck joshnck left review comments

@nasbench nasbench nasbench approved these changes

@thomaspatzke thomaspatzke thomaspatzke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frack113 @thomaspatzke @nasbench @joshnck