Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏓🍤 ↝ [SGV2-200 SSG-1 #148]: Update GuideBot and CompletedMissions components #149

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Rhysmalcolm13
Copy link

@Rhysmalcolm13 Rhysmalcolm13 commented Sep 19, 2024

  1. Consolidated Data Fetching:
    -Used Promise.all to fetch data concurrently.
  2. Consistent State Management:
  • Ensured that state management for missions and active missions is consistent.
  • Added error handling to display error messages when necessary.
  1. TypeScript Types:
  • Ensured that TypeScript types are correctly used and defined.

Huly®: STAR_-109

- Modify GuideBot in (dialogue) folder
- Adjust CompletedMissions in (missions) folder
Copy link

height bot commented Sep 19, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@Gizmotronn Gizmotronn changed the title Update GuideBot and CompletedMissions components 🏓🍤 ↝ [SGV2-200 SSG-1 #148]: Update GuideBot and CompletedMissions components Sep 19, 2024
@Gizmotronn
Copy link
Member

#148

Gizmotronn added a commit that referenced this pull request Sep 19, 2024
…og, some information, and some zoodex configurator components
Copy link
Member

@Gizmotronn Gizmotronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Now we just need to get a minimal instruction manual put into the guidebot so that users can navigate the weird/half-broken parts of the prod deployment.
Main thing is getting some feedback about the new modules and UI, narrative

'' is now there, so users can choose to then go onto the next thing.

Okay, I've gone through everything. Sequencing seems to have been improved, not all the missions work but the main ones do. Putting the component into the guidebot should at least allow users to switch so they can do more than one thing.

Okay, so two issues:

  1. After the user does their first classification, the user has to click "reset mission" for the mining one to take place (however this does seem to work as then the 'Automaton Structure' becomes the "active structure"). However, mining then doesn't trigger the mining mission to be done (but that is not likely to be a sequencing thing, more to do with the way mining works, so that's on me).

Continuing testing...

(in short, I don't see any issues that are to do with your code, just issues with the flow in general...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants