Fix flake8 issues #1007
Merged
Fix flake8 issues #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can later gradually make it stricter until we have no errors anymore.
…finition of errors
richbeales
previously approved these changes
Apr 12, 2023
richbeales
approved these changes
Apr 12, 2023
5 tasks
SquareandCompass
pushed a commit
to SquareandCompass/Auto-GPT
that referenced
this pull request
Oct 21, 2023
…and tune (Significant-Gravitas#1007) * version update post release v1.2.2 * automl option * import pandas * remove automl.utils * default * test * type hint and version update * dependency update * link to open in colab * use packging.version to close Significant-Gravitas#725 --------- Co-authored-by: Li Jiang <lijiang1@microsoft.com> Co-authored-by: Li Jiang <bnujli@gmail.com>
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…e8-issues Fix flake8 issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Recently, the #923 PR was merged, adding the
flake8linting job to theci.ymlworkflow. Currently this job returns many linting errors that need to be fixed. @nponeccop then suggested to narrow the amount of linting errors to be returned by altering theflake8command in the job so that the list of errors would become manageable. After that first list of linting errors are fixed, we can gradually ignore less errors and fix them until we have no linting errors in the project anymore.Changes
flake8linting command to only respond to a specific amount of linting errorscontinue-on-errortofalseto enforce code quality for this narrower amount of linting errorsflake8used in CI inREADME.mdDocumentation
README.mdhas been updated with regards to rules.Test Plan
As
continue-on-erroris now set tofalse, the CI should now succeed in order to be able to merge the PR. And if it succeeds, it also means the narrower set of linting errors have been fixed properly.PR Quality Checklist