Fix agent key error #1507
Merged
Fix agent key error #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nponeccop replacement for #1341 |
|
@jacobtohahn There are conflicts now |
|
@nponeccop thanks for the heads up, just resolved them |
nponeccop
approved these changes
Apr 15, 2023
richbeales
approved these changes
Apr 15, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…nt_key_error Fix agent key error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
If AutoGPT attempted to use message_agent with the key as a string [STRING], the command would return "Error: invalid literal for int() with base 10: '[STRING]'". This confused the AI and could lead to loops or JSON errors.
Changes
Before, the message_agent function in commands.py allowed the key to be a string, generating the error described above.
The message_agent function has been modified to only allow the key to be an integer, returning "Invalid key, must be an integer." if it is not.
Documentation
Test Plan
The changes were tested by using human feedback to instruct the agent to use a string as a key, and verifying the command returned "Invalid key, must be an integer." if it was. The agent was then allowed to use an integer as a key, which produced the expected result.
PR Quality Checklist