Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add execute shell scripts to prompt if AI is allowed to do it. #1551

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

richbeales
Copy link
Contributor

Background

To prevent issues where

SYSTEM: Command execute_shell returned: You are not allowed to run local shell commands. To execute shell commands, EXECUTE_LOCAL_COMMANDS must be set to 'True' in your config. Do not attempt to bypass the restriction.
THOUGHTS: Running the 'execute_shell' command failed because I am not authorized to run shell commands

We should not surface this command to the AI in the prompt unless it's allowed to execute it.

Changes

alter prompt.py

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@nponeccop
Copy link
Contributor

@richbeales There are conflicts now

nponeccop
nponeccop previously approved these changes Apr 15, 2023
@nponeccop
Copy link
Contributor

@richbeales There are conflicts now

1 similar comment
@nponeccop
Copy link
Contributor

@richbeales There are conflicts now

@richbeales
Copy link
Contributor Author

@nponeccop resolved

@p-i- p-i- merged commit 5f4e317 into master Apr 15, 2023
@p-i- p-i- deleted the richbeales-patch-2 branch April 15, 2023 17:25
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants