Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Write unit tests for token_counter #1567

Merged

Conversation

drikusroor
Copy link
Contributor

Background

A few days ago, we've added automated unit tests using Github workflow. This PR expands the coverage of the unit tests by covering the token_counter.py module.

Changes

  • Add unit tests for token_counter.py
  • Fix minor typo in token_counter.py

Documentation

  • N/A

Test Plan

  • Unit tests should succeed
  • (optional) Ask author(s) of token_counter.py and check if they agree

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@drikusroor drikusroor force-pushed the cover-token-counter branch from f321185 to bdefa24 Compare April 15, 2023 13:11
@nponeccop
Copy link
Contributor

@drikusroor CI failed

@drikusroor
Copy link
Contributor Author

@drikusroor CI failed

You're quick! I've fixed the CI ✅👌

@richbeales richbeales merged commit 26ffa41 into Significant-Gravitas:master Apr 15, 2023
@nponeccop nponeccop mentioned this pull request Apr 15, 2023
1 task
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
…ken-counter

test: Write unit tests for token_counter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants