Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file logging infinite loop issue #1901

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

rocks6
Copy link
Contributor

@rocks6 rocks6 commented Apr 16, 2023

Background

There is a new file logging capability that logs every file operation to file_logger.txt. However, the append operation creates another log line, which creates another append operation, etc.

Changes

Added a bool which controls whether the append operation should log.

Documentation

Trivial

Test Plan

Ran unit tests and verified the file operations from autogpt no longer produce this:
image

PR Quality Checklist

  • [x ] My pull request is atomic and focuses on a single change.
  • [ x] I have thoroughly tested my changes with multiple different prompts.
  • [x ] I have considered potential risks and mitigations for my changes.
  • [n/a ] I have documented my changes clearly and comprehensively.
  • [ x] I have not snuck in any "extra" small tweaks changes

nponeccop
nponeccop previously approved these changes Apr 16, 2023
@nponeccop
Copy link
Contributor

@rocks6 CI is red

@p-i- p-i- merged commit ccf3c7b into Significant-Gravitas:master Apr 16, 2023
@dgiovanzana
Copy link

I am still having this issue. Did the patch work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants