Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PULL_REQUEST_TEMPLATE.md #334

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

hunteraraujo
Copy link
Contributor

Background

Currently we have a mass amount of PRs and it is becoming difficult to look at all of them in an efficient manner. We need a standardized way to see what is going on in a PR to streamline reviewing.

Changes

This PR adds a new GitHub template to allow the developer to quickly and easily provide the relevant information.

Test Plan

Raise a PR and verify template works.

Change Safety

  • I have added tests to cover my changes
  • I have considered potential risks and mitigations for my changes

Screenshot 2023-04-06 at 10 00 55 AM

dschonholtz
dschonholtz previously approved these changes Apr 6, 2023
Copy link
Contributor

@dschonholtz dschonholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initial start on this. I imagine we'll find more things we'll want over time. But this is great for now.

Copy link
Contributor

@dwrtz dwrtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Torantulino
Copy link
Member

Brilliant, thank you for adding this!

This will be a huge help.

@Torantulino Torantulino merged commit c6d9022 into Significant-Gravitas:master Apr 7, 2023
@jmanhype
Copy link

jmanhype commented Apr 7, 2023

I dont know where to add this but we need CMD prmpt access in the bot. Like let it do command prompt tasks

@jmanhype
Copy link

jmanhype commented Apr 7, 2023

To further improve the JSON response format, consider the following suggestions:

  1. Add a 'status' field: Introduce a 'status' field to indicate the state of the AI's operation, such as "success," "error," or "in_progress." This will help users easily understand the outcome and status of the AI's response.

  2. Allow multiple commands: Modify the 'command' section to accommodate an array of commands, allowing the AI to execute multiple actions in a single response. This enhances the versatility and efficiency of the AI's communication.

  3. Add a 'confidence' field: Introduce a 'confidence' field in the 'thoughts' section to indicate the AI's level of certainty in its response. This can help users gauge the reliability of the AI's suggestions and reasoning.

  4. Improve error handling: Include an 'error' field that provides a detailed description of any errors or issues encountered during the AI's operation. This will enable users to better understand and address potential problems.

By implementing these suggestions, the JSON response format will be more informative, versatile, and user-friendly, leading to an enhanced experience for users interacting with the AI system.

waynehamadi pushed a commit that referenced this pull request Sep 5, 2023
Co-authored-by: Luke <2609441+lc0rp@user.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants