Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update print_to_console to log to a text file #574

Merged
merged 16 commits into from
Apr 10, 2023

Conversation

richbeales
Copy link
Contributor

Uses python logging module to output progress to a text file log.txt

Background

Changes

Test Plan

Change Safety

  • I have added tests to cover my changes
  • I have considered potential risks and mitigations for my changes

Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unrelated changes

scripts/main.py Outdated Show resolved Hide resolved
scripts/main.py Outdated Show resolved Hide resolved
scripts/main.py Outdated Show resolved Hide resolved
nponeccop
nponeccop previously approved these changes Apr 10, 2023
@richbeales
Copy link
Contributor Author

PR updated with latest main.py to resolve merge conflict.

@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@Torantulino
Copy link
Member

Torantulino commented Apr 10, 2023

Excellent, thank you @richbeales.
Cheers @nponeccop for your reviews and getting this focused!

@Torantulino Torantulino merged commit 5cd48d5 into Significant-Gravitas:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants