Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the conflict around debug mode flag after pull merge #678

Conversation

kinance
Copy link
Contributor

@kinance kinance commented Apr 10, 2023

Background

To resolve the conflict around the debug mode flag after pull merge. cfg.debug and cfg.debug_mode was checked in by different pull requests. They conflicted.

Changes

The change is to keep cfg.debug_mode because it's consistent with other modes, so 1. revised the parts using cfg.debug to use cfg.debug_mode, and 2. kept the parts using cfg.debug_mode.

Documentation

Part of the codes already have comments. It's a simple commit to resolve conflicts.

Test Plan

Tested with running with --debug in command line.

PR Quality Checklist

  • [*] My pull request is atomic and focuses on a single change.
  • [*] I have thouroughly tested my changes with multiple different prompts.
  • [*] I have considered potential risks and mitigations for my changes.
  • [*] I have documented my changes clearly and comprehensively.
  • [*] I have not snuck in any "extra" small tweaks changes

@kinance
Copy link
Contributor Author

kinance commented Apr 10, 2023

@nponeccop @Torantulino Please help review to resolve conflicts around debug mode, #457

@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@Torantulino Torantulino merged commit 186a8c6 into Significant-Gravitas:master Apr 11, 2023
@kinance kinance deleted the kinance-resolve-debug-config-conflict branch June 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants