Resolve the conflict around debug mode flag after pull merge #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
To resolve the conflict around the debug mode flag after pull merge. cfg.debug and cfg.debug_mode was checked in by different pull requests. They conflicted.
Changes
The change is to keep cfg.debug_mode because it's consistent with other modes, so 1. revised the parts using cfg.debug to use cfg.debug_mode, and 2. kept the parts using cfg.debug_mode.
Documentation
Part of the codes already have comments. It's a simple commit to resolve conflicts.
Test Plan
Tested with running with --debug in command line.
PR Quality Checklist