-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix command order skip in prompt.txt #760
Fix command order skip in prompt.txt #760
Conversation
- removes skip in #s in the order of the commands in prompt.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like we need benchmarking to prove it out before implementing.
Pretty sure fixing a formatting error does not necessarily require benchmarking. |
You're right, I misread it |
I wonder if the prompt numbering is intentional, allowing to insert new pieces of prompt in the middle? @Torantulino? If it's a bug, the fix LGTM |
Why wouldn't someone just fix the numbering if they want to add/remove a command? Having a gap in the numbering seems more likely to confuse the AI |
Because they patch prompts frequently and the renumbering is tedious? |
I created a new PR that addresses the fact that renumbering is tedious: #837 |
Why is it closed? |
closing this in favour of #837 |
* Discord Badge Discord Badge added Issue Significant-Gravitas#749 * style changed plastic style to flat style
Removes skip in #s in the order of the commands in prompt.txt
Background
Got tired of seeing the # skip in the prompt.txt and always noticed that there were less "failed to parse AI output" and "Invalid JSON" issues after fixing the order
Changes
Removes the skips in the order of commands in the
prompt.txt
fileDocumentation
prompt.txt is self-documenting
Test Plan
Ran a few test runs with basic prompts
PR Quality Checklist