Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command order skip in prompt.txt #760

Closed
wants to merge 1 commit into from
Closed

Fix command order skip in prompt.txt #760

wants to merge 1 commit into from

Conversation

AlrikOlson
Copy link
Contributor

@AlrikOlson AlrikOlson commented Apr 11, 2023

Removes skip in #s in the order of the commands in prompt.txt

Background

Got tired of seeing the # skip in the prompt.txt and always noticed that there were less "failed to parse AI output" and "Invalid JSON" issues after fixing the order

Changes

Removes the skips in the order of commands in the prompt.txt file

Documentation

prompt.txt is self-documenting

Test Plan

Ran a few test runs with basic prompts

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

- removes skip in #s in the order of the commands in prompt.txt
@AlrikOlson AlrikOlson changed the title fix: command order skip in prompt.txt Fix command order skip in prompt.txt Apr 11, 2023
Copy link
Contributor

@richbeales richbeales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like we need benchmarking to prove it out before implementing.

@Romelium
Copy link

This feels like we need benchmarking to prove it out before implementing.

Pretty sure fixing a formatting error does not necessarily require benchmarking.

@richbeales
Copy link
Contributor

You're right, I misread it

@nponeccop
Copy link
Contributor

I wonder if the prompt numbering is intentional, allowing to insert new pieces of prompt in the middle? @Torantulino? If it's a bug, the fix LGTM

@AlrikOlson
Copy link
Contributor Author

AlrikOlson commented Apr 11, 2023

I wonder if the prompt numbering is intentional, allowing to insert new pieces of prompt in the middle? @Torantulino? If it's a bug, the fix LGTM

Why wouldn't someone just fix the numbering if they want to add/remove a command? Having a gap in the numbering seems more likely to confuse the AI

@nponeccop
Copy link
Contributor

Because they patch prompts frequently and the renumbering is tedious?

@AlrikOlson
Copy link
Contributor Author

I created a new PR that addresses the fact that renumbering is tedious: #837

@nponeccop
Copy link
Contributor

Why is it closed?

@richbeales
Copy link
Contributor

closing this in favour of #837

@richbeales richbeales closed this Apr 13, 2023
SquareandCompass pushed a commit to SquareandCompass/Auto-GPT that referenced this pull request Oct 21, 2023
* Discord Badge 

Discord Badge added Issue Significant-Gravitas#749

* style changed

plastic style to flat style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants