-
Notifications
You must be signed in to change notification settings - Fork 44.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): sentry integration #8053
feat(builder): sentry integration #8053
Conversation
PR Reviewer Guide 🔍
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
https://docs.sentry.io/concepts/key-terms/dsn-explainer/#dsn-utilization |
…r-activitiyevents
What does sentry offer that we are not currently getting with google analytics? |
Backend errors and enables tracing errors through end to end. Also includes things like replays but I'm pretty sure GA offers that. Also handles ad blockers by sending analytics from the backend |
…r-activitiyevents
const all = rows.map((row) => removeFeaturedAgent(row.id)); | ||
await Promise.all(all); | ||
revalidatePath("/marketplace"); | ||
return await Sentry.withServerActionInstrumentation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think this is definitely worth a follow-up:
The changes wrapping sentry here can be a wrapper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agree
Background
We want to track errors in the frontend
Changes 🏗️
Adds sentry and configures a few of its more straightforward settings to meet our goals. The main one I changed was the actions to work
(note 90%+ of this was scaffolded by the sentry wizard 🧙 )
PR Quality Scorecard ✨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance?+10 pts