Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Fix unexpected connection clash on two dynamic pins link with the same keys #8252

Merged

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Oct 3, 2024

Background

image

When you connect a dynamic input pin with the same key, both pins will always be treated identically.

The example above: output is connected to #key1, but the #key1 on the other non-connected block also loses its input field indicating it's also connected

Changes 🏗️

Fix connection checking by adding nodeId into the equation.

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@majdyz majdyz requested a review from a team as a code owner October 3, 2024 01:57
@majdyz majdyz requested review from ntindle and Swiftyos and removed request for a team October 3, 2024 01:57
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Oct 3, 2024
Copy link

qodo-merge-pro bot commented Oct 3, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Unnecessary Console Log
A console.log statement has been added for debugging purposes and should be removed before merging.

Code Duplication
The isConnected function is implemented twice with similar logic. Consider refactoring to avoid duplication.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 4ee4486
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67069e16759ec100080aca92

@majdyz majdyz requested review from ntindle and Swiftyos and removed request for ntindle and Swiftyos October 7, 2024 08:44
@majdyz majdyz enabled auto-merge (squash) October 7, 2024 21:17
@github-actions github-actions bot added size/xl and removed size/m labels Oct 7, 2024
@majdyz majdyz requested a review from Torantulino October 7, 2024 22:43
@Torantulino Torantulino requested review from Pwuts and aarushik93 and removed request for Swiftyos October 8, 2024 18:48
@majdyz majdyz merged commit dbc603c into master Oct 9, 2024
14 checks passed
@majdyz majdyz deleted the zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin branch October 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/xl
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants