-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Fix unexpected connection clash on two dynamic pins link with the same keys #8252
Merged
majdyz
merged 17 commits into
master
from
zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
Oct 9, 2024
Merged
fix(platform): Fix unexpected connection clash on two dynamic pins link with the same keys #8252
majdyz
merged 17 commits into
master
from
zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
Oct 9, 2024
+678
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majdyz
requested review from
ntindle and
Swiftyos
and removed request for
a team
October 3, 2024 01:57
github-actions
bot
added
platform/frontend
AutoGPT Platform - Front end
platform/backend
AutoGPT Platform - Back end
labels
Oct 3, 2024
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
… zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
…' of github.com:Significant-Gravitas/AutoGPT into zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
…de-on-dynamic-input-pin' into zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
Torantulino
requested review from
Pwuts and
aarushik93
and removed request for
Swiftyos
October 8, 2024 18:48
ntindle
approved these changes
Oct 9, 2024
majdyz
deleted the
zamilmajdy/open-1911-clashing-node-on-dynamic-input-pin
branch
October 9, 2024 20:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform/backend
AutoGPT Platform - Back end
platform/frontend
AutoGPT Platform - Front end
Review effort [1-5]: 2
size/xl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When you connect a dynamic input pin with the same key, both pins will always be treated identically.
The example above: output is connected to #key1, but the #key1 on the other non-connected block also loses its input field indicating it's also connected
Changes 🏗️
Fix connection checking by adding nodeId into the equation.
Testing 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/