-
Notifications
You must be signed in to change notification settings - Fork 44.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): Add delete agent functionality #8273
feat(platform): Add delete agent functionality #8273
Conversation
… zamilmajdy/open-1841-implement-delete-functionality-for-agents
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to point out that using TypedDict is causing some issues since our Docker image is based on Python 3.11. Pydantic doesn’t fully support typing.TypedDict in versions below Python 3.12, which is why we're seeing those errors.
To fix this, we need to replace from typing import TypedDict with from typing_extensions import TypedDict. This should make it compatible with our current setup.
@Swiftyos why don't we just update the docker image? |
this clashes with #8272. I can close my PR or you can remove the migrations from yours and use the ones i created |
@majdyz if you upgrade docker files lets do it in a diff PR please |
@aarushik93 I can remove the change on my end, would you mind to add some of the changes I added on my PR if it's not there already on your PR? |
@majdyz yeah sure thing - what changes would you like added? |
@aarushik93 nvm ur pr has been auto merged :) |
… zamilmajdy/open-1841-implement-delete-functionality-for-agents
…tionality-for-agents
LGTM - do you wanna get the Docker change in first before merging this though? |
…tionality-for-agents
@aarushik93 the change no longer requires higher python version fortunately |
…tionality-for-agents
Background
We are not able to remove an agent.
Changes 🏗️
Added UI & API for deleting an Agent.
Testing 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/