Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/infra): Create prod service account and pool #8383

Merged

Conversation

aarushik93
Copy link
Contributor

Background

Need a service account with the right perms for prod

Changes 🏗️

created a prod service account
created a workload identity pool
gave account all the right permissions

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner October 21, 2024 10:16
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/l labels Oct 21, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR introduces new service account emails and workload identity pool configurations in the Terraform files (dev.tfvars and prod.tfvars). While these are typically not considered secrets, they could potentially be used in conjunction with other information for unauthorized access. It's important to ensure that these configurations are appropriate for the intended environment and that access is properly restricted.

⚡ Recommended focus areas for review

Security Concern
The attribute condition in the google_iam_workload_identity_pool_provider resource is hardcoded to a specific repository owner. This might limit flexibility and require manual updates if the repository ownership changes.

Potential Misconfiguration
The workflow is configured to run on push to the 'dev' branch, but it's deploying to production environments. This could lead to unintended deployments to production.

Configuration Error
The liveness probe path has been changed from '/heath' to '/health'. Ensure this is the correct endpoint for the health check.

@aarushik93 aarushik93 changed the base branch from dev to aarushikansal/secrt-944-set-up-deploys-from-dev October 21, 2024 10:23
Swiftyos
Swiftyos previously approved these changes Oct 22, 2024
Base automatically changed from aarushikansal/secrt-944-set-up-deploys-from-dev to dev October 22, 2024 13:45
@aarushik93 aarushik93 dismissed Swiftyos’s stale review October 22, 2024 13:45

The base branch was changed.

@github-actions github-actions bot added size/m and removed size/l labels Oct 22, 2024
@aarushik93 aarushik93 merged commit 37607d1 into dev Oct 23, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/secrt-953-create-production-account-pool-for-ci branch October 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants