Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): Introduced Agent Execution Block #8533

Merged

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 4, 2024

Background

This change depends on: #8526

Now the created agents will be available on the block list and can be used as part of the other graph.

image image

Changes 🏗️

Introduced Agent execution as a block/node in a graph.

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 4, 2024 01:18
@majdyz majdyz requested review from ntindle and kcze and removed request for a team November 4, 2024 01:18
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks labels Nov 4, 2024
Copy link

qodo-merge-pro bot commented Nov 4, 2024

PR Reviewer Guide 🔍

(Review updated until commit 4167977)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling
The AgentExecutorBlock's run method lacks proper error handling. It should catch and handle potential exceptions from the executor_manager and event_bus operations.

Type Consistency
The from_graph method in ExecutionResult creates an instance with empty input_data and output_data. This might lead to inconsistencies if these fields are expected to be populated.

Performance Concern
The addNode function creates a new node on every call. For better performance, consider memoizing this function or its result.

…milmajdy/secrt-956-integrate-connection-object-to-the-block-code
Base automatically changed from zamilmajdy/unifygraphmeta-and-graph to dev November 7, 2024 02:30
@majdyz majdyz dismissed stale reviews from aarushik93 and ntindle November 7, 2024 02:30

The base branch was changed.

@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

…milmajdy/secrt-956-integrate-connection-object-to-the-block-code
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts and removed conflicts Automatically applied to PRs with merge conflicts labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@majdyz
Copy link
Contributor Author

majdyz commented Nov 7, 2024

@ntindle I'll check if I can replicate

…milmajdy/secrt-956-integrate-connection-object-to-the-block-code
…onnection-object-to-the-block-code' into zamilmajdy/secrt-956-integrate-connection-object-to-the-block-code
@majdyz
Copy link
Contributor Author

majdyz commented Nov 7, 2024

@ntindle I'm not able to repro the credentials issue. for the consumed beads what is the output blocks being used?

@majdyz majdyz requested review from aarushik93 and ntindle November 7, 2024 13:18
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit cb9abff
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6732ebc8a4df5a00085d1a8a

@majdyz majdyz merged commit 1e87240 into dev Nov 12, 2024
17 checks passed
@majdyz majdyz deleted the zamilmajdy/secrt-956-integrate-connection-object-to-the-block-code branch November 12, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants