Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Define executionmanager hostname for local docker-mode #8681

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 18, 2024

When running in local docker-mode, the executor is unable to access the pyro server of the execution manager with this error:
Node execution failed with error cannot connect to ('localhost', 8002): [Errno 111] Connection refused.

Changes 🏗️

Define executionmanager hostname for local docker-mode

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 18, 2024 04:10
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR contains a hardcoded encryption key in the docker-compose file (ENCRYPTION_KEY). While marked as not for production use, it's recommended to move this to a secure configuration management system or environment variable to prevent accidental use in production environments.

⚡ Recommended focus areas for review

Configuration Validation
Verify that the EXECUTIONMANAGER_HOST value of '0.0.0.0' is the correct binding address for the execution manager service in docker mode

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 2f95d59
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673abe553ca6990008b985cf

@aarushik93 aarushik93 merged commit a2895a2 into dev Nov 18, 2024
13 checks passed
@aarushik93 aarushik93 deleted the zamilmajdy/fix-docker-mode-agent-executor branch November 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants