Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend): Simplify CredentialsField usage + use ProviderName globally #8725

Merged
merged 9 commits into from
Dec 11, 2024
Merged

refactor(backend): Simplify CredentialsField usage + use ProviderName globally #8725

merged 9 commits into from
Dec 11, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 20, 2024 •
edited
Loading

Changes 🏗️

  • Avoid double specifying provider and cred types on credentials inputs
    • Move credentials sub-schema validation from CredentialsField to CredentialsMetaInput.validate_credentials_field_schema(..), which is called in BlockSchema.__pydantic_init_subclass__
  • Use ProviderName enum globally

@Pwuts Pwuts requested a review from a team as a code owner November 20, 2024 00:22
@Pwuts Pwuts requested review from Bentlybro and majdyz and removed request for a team November 20, 2024 00:22
@github-actions github-actions bot added documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 20, 2024
@Pwuts Pwuts mentioned this pull request Nov 20, 2024
Merged
14 tasks
@Pwuts Pwuts requested a review from ntindle November 20, 2024 09:44
@aarushik93
Copy link
Contributor

Haven't reviewed or tested yet - but is this going to be a breaking change for ppls existing blocks at all?

@majdyz majdyz removed their request for review November 20, 2024 12:52
@Pwuts
Copy link
Member Author

Pwuts commented Nov 20, 2024

is this going to be a breaking change for ppls existing blocks at all?

Nope, this is purely a refactor for DX purposes. Serialization and validation of existing objects shouldn't be affected.

@Pwuts Pwuts force-pushed the reinier/open-1961-implement-github-on-pull-request-block branch from c415bd0 to 397ae0b Compare November 21, 2024 19:09
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

kcze
kcze previously approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@kcze kcze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

autogpt_platform/backend/backend/blocks/github/_auth.py Show resolved Hide resolved
Base automatically changed from reinier/open-1961-implement-github-on-pull-request-block to dev November 25, 2024 17:42
@Pwuts Pwuts dismissed kcze’s stale review November 25, 2024 17:42

The base branch was changed.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 11f82b9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6759e3dff5130f00081c51d4

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts Pwuts requested review from ntindle, kcze and aarushik93 November 30, 2024 17:54
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

ntindle
ntindle previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/xl and removed size/l labels Dec 10, 2024
@Pwuts Pwuts mentioned this pull request Dec 10, 2024
Open
4 tasks
ntindle
ntindle previously approved these changes Dec 10, 2024
View reviewed changes
@Pwuts Pwuts enabled auto-merge December 11, 2024 19:24
@Pwuts Pwuts mentioned this pull request Dec 11, 2024
Open
@Pwuts Pwuts added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 33b9eef Dec 11, 2024
19 checks passed
@Pwuts Pwuts deleted the reinier/make-providername-enum branch December 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

@kcze kcze Awaiting requested review from kcze

@aarushik93 aarushik93 Awaiting requested review from aarushik93

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end platform/blocks size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pwuts @aarushik93 @ntindle @kcze