fix(frontend): Automatically choose client/server-side API client #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pwuts
requested review from
ntindle and
Torantulino
and removed request for
a team
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
github-actions
bot
added
platform/frontend
✅ Deploy Preview for auto-gpt-docs canceled.
|
kcze
reviewed
Dec 9, 2024
| @@ -1,5 +1,6 @@ | |||
| import { AutoGPTServerAPI } from "./client"; | |||
|
|
|||
| // TODO: rename to BackendAPI | |||
There was a problem hiding this comment.
Out of scope, would cause a huge amount of changes and also conflicts on ongoing PRs
There was a problem hiding this comment.
Are there no imports of this anywhere?
|
@Pwuts getting this error after making these changes? 
|
|
I spent a lot of time playing this game, and couldn’t get it working which is why I had it the other way. I think making test components for each would probably be productive as you try various methods |
Pwuts
deleted the
reinier/open-2147-automatic-server-sideclient-side-backend-api-client-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useBackendAPIhook introduced in feat(blocks): Add webhook block status indicator #8838We have separate client-side and server-side API clients. Choosing the right one should be done in the exporting module, not in all import locations.
Changes 🏗️
AutoGPTServerAPItoAutoGPTServerAPIClientSideautogpt-server-api/clientServerintoautogpt-server-api/clientAutoGPTServerAPIexport inautogpt-server-api/clientChecklist 📋
For code changes:
Example test plan