-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QRF orbital #144
QRF orbital #144
Conversation
Almost forgot. After testing we need to move this QRF in "futuristic" option and move Orbital beam to something like "futuristic-unfair". Of course, this option will need to be added to the menu, but I don't think it would be too difficult to do. |
This is a continuation of #126 |
Star wars modset needs droppods added (I think CIS has droppods(either as a propper vehicle or as scenery object) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if a template doesn't have a vehiclesDropPod
?
Yep, forgot about that one, might check how absence of helicopters is handled |
Just realized, I should probably add stuff like blowing door panel on ODST pod, or opening the doors on other pods. Just stuff like that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally you just need to clean up commented out code that isn't needed, and properly fill out function headers so their args and such are correct
A3A/addons/core/functions/CREATE/fn_createAttackForceOrbital.sqf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be smart to double check all of the "get" and swap them to getOrDefault given the issues we had with it last release
Just the |
I think there is no need for that since there is a droppod in faction defaults, thought I think we need to check the crashsite mission check for droppod, I don't think it will spawn satellite version of the mission if there is no droppod in the template since we doing getordefault check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove commented out segments of code that are no longer needed, makes it unnecessarily hard to read
A3A/addons/core/functions/Missions/fn_LOG_Crashsite_Satellite.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/functions/Missions/fn_LOG_Crashsite_Satellite.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/functions/Missions/fn_LOG_Crashsite_Satellite.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/functions/CREATE/fn_createVehicleQRFBehaviour.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/functions/CREATE/fn_createVehicleQRFBehaviour.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/functions/CREATE/fn_createAttackForceOrbital.sqf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for testing I think
What type of PR is this.
What have you changed and why?
Information:
OKAY. This is kinda huge. Initial draft or whatever. A lot to do(wright code and test). I believe I created all necessary files, but I'm no expert on supports and especially QRFs.
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes:
Added some notes in fn_orbitalLanding on how qrf should behave. Maybe in the future include Orbital vehicle drop?
For now only NATO arid and CSAT arid have droppods. After testing, OPTRE and other modsets will receive them as well