Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and Fixed some strings (Psycool3695) #199

Merged
merged 2 commits into from
May 12, 2024

Conversation

SilenceIsFatto
Copy link
Owner

What type of PR is this?

  1. Bug
  2. Change
  3. Enhancement
  4. Miscellaneous

What have you changed and why?

Information: Added missing Korean strings, fixed "<;/Key>>" to "<;/Key>" and improved some Koreans.
P.S: The semicolon was added intentionally so that this character would appear in this article. Of course, Stringtable doesn't have that.

This is a duplicate of Psycool3695-unstable by Psycool3695 that resolves the merge issues of the original PR (#164)

Please specify which Issue this PR Resolves (If Applicable).

"This PR closes #XXXX!"

Please verify the following.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps: Just change the language of the game to Korean and run it.


Notes: I didn't test as a dedicated server. After all, there is meaningless in testing the dedicated server because it runs only with the Original string, not the language of the server's country.

@SilenceIsFatto SilenceIsFatto mentioned this pull request May 9, 2024
8 tasks
@SilenceIsFatto SilenceIsFatto merged commit 275c125 into unstable May 12, 2024
@SilenceIsFatto SilenceIsFatto deleted the Psycool3695-unstable branch September 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants