forked from igorkis-scrts/A3-Antistasi-Plus
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black market vehicle changes #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… categories and black market vehicles depend on same addons base class
+ Vehicle conditions are now done via macro and the python scripts have been cleaned up
SilenceIsFatto
commented
Jun 4, 2024
SilenceIsFatto
added
enhancement
New feature or request
misc
A miscellaneous change
labels
Jun 6, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTINUATION OF #73 by @Westalgie
What type of PR is this.
What have you changed and why?
Black market vehicles are now done similar to the weapons, in which vehicles will be added from all available supported modsets.
Vehicles and weapons are now both linked to addons, rather than the addons being linked to the vehicles/weapons.
Conditions have been correctly implemented along with changes to the csvparser python script.
Unlock Conditions are now linked to the vehicle type.
Use the new tool called
csvparser
and read the documentation provided in order to generate the macro lists.A few examples:
Vanilla:
IFA3
CUP With a few CUP based mods
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
To unlock AA, you will need:
1 Seaport or 3 Resources and 3 Factories.
To unlock Unarmed Cars, you will need:
1 Resource and 1 Factory
Full list here
Notes:
The provided google drive link is a copied variant of the private one, and as such will not update when the private one updates. Take the info from the sheet with a grain of salt and consult the code for concrete information.
Check for messages in .rpt file
In cases where more zones are required than is possible on the current map, it will still count if you own every zone of that type.
E.g: Tanks require 5 factories but X map only has 3. Capturing all 3 will count and you will unlock Tanks (provided you also meet the other requirements)