Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black market vehicle changes #212

Merged
merged 53 commits into from
Jun 16, 2024
Merged

Black market vehicle changes #212

merged 53 commits into from
Jun 16, 2024

Conversation

SilenceIsFatto
Copy link
Owner

@SilenceIsFatto SilenceIsFatto commented Jun 2, 2024

CONTINUATION OF #73 by @Westalgie

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Black market vehicles are now done similar to the weapons, in which vehicles will be added from all available supported modsets.

Vehicles and weapons are now both linked to addons, rather than the addons being linked to the vehicles/weapons.

Conditions have been correctly implemented along with changes to the csvparser python script.

Unlock Conditions are now linked to the vehicle type.

Use the new tool called csvparser and read the documentation provided in order to generate the macro lists.

A few examples:

Vanilla:

107410_20240604232712_1

IFA3

image
image

CUP With a few CUP based mods

image
image

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

To unlock AA, you will need:
1 Seaport or 3 Resources and 3 Factories.

To unlock Unarmed Cars, you will need:
1 Resource and 1 Factory

Full list here


Notes:

The provided google drive link is a copied variant of the private one, and as such will not update when the private one updates. Take the info from the sheet with a grain of salt and consult the code for concrete information.

Check for messages in .rpt file

In cases where more zones are required than is possible on the current map, it will still count if you own every zone of that type.
E.g: Tanks require 5 factories but X map only has 3. Capturing all 3 will count and you will unlock Tanks (provided you also meet the other requirements)

@SilenceIsFatto SilenceIsFatto mentioned this pull request Jun 5, 2024
7 tasks
@SilenceIsFatto SilenceIsFatto added enhancement New feature or request misc A miscellaneous change labels Jun 6, 2024
@stutpip123 stutpip123 mentioned this pull request Jun 13, 2024
8 tasks
@SilenceIsFatto SilenceIsFatto merged commit da6636e into unstable Jun 16, 2024
@SilenceIsFatto SilenceIsFatto mentioned this pull request Jul 31, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request misc A miscellaneous change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants