Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue jest 14766 #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix issue jest 14766 #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a922e83
fix issue jest 14766
cenfun Mar 19, 2024
c36c3e5
added Debugger.disable
cenfun Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class CoverageInstrumenter {
async startInstrumenting() {
this.session.connect();

await this.postSession('Debugger.enable');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be disabled on exit then I assume?

It seems odd to me we need to enable the debugger, tho. any immediate ideas on why?


await this.postSession('Profiler.enable');

await this.postSession('Profiler.startPreciseCoverage', {
Expand All @@ -30,6 +32,8 @@ class CoverageInstrumenter {

await this.postSession('Profiler.disable');

await this.postSession('Debugger.disable');

// When using networked filesystems on Windows, v8 sometimes returns URLs
// of the form file:////<host>/path. These URLs are not well understood
// by NodeJS (see https://github.com/nodejs/node/issues/48530).
Expand Down