Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to stop recording #163

Closed
hatemragab opened this issue Feb 21, 2023 · 18 comments · Fixed by #167
Closed

Failed to stop recording #163

hatemragab opened this issue Feb 21, 2023 · 18 comments · Fixed by #167
Labels
bug Something isn't working

Comments

@hatemragab
Copy link

hatemragab commented Feb 21, 2023

i have upgraded from v 1.0.1 to v 1.0.2 i have and when the call stop
Failed to stop recording
Android
first call for this final path = await recorder.stop(); works good when i try to record again and stop it not working

@Colton127
Copy link

I am experiencing the same issue.

@dimasnurab
Copy link

same issue

1 similar comment
@annt99
Copy link

annt99 commented Feb 24, 2023

same issue

@reliance-engineer
Copy link

same here

@hatemragab
Copy link
Author

And the big problem is when back to Old version it wasn't working 😅

@reliance-engineer
Copy link

I've found that the problem happens after I call controller.dispose(), even if I create a new one I can't stop recording anymore

@Ujas-Majithiya
Copy link
Collaborator

Thanks for reporting this issue. I will look into this on Monday. Until then you might wanna use version 1.0.1. In pubspec, if you have '^' ahead of version then remove it. It will still consider latest minor version if you have added '^'.

@ujas-m-simformsolutions
Copy link
Collaborator

@hatemragab Can you please share which flutter version you are using and reproducible code because I tried on android device and I can't reproduce it.

@hatemragab
Copy link
Author

I use current most stable version

@Ujas-Majithiya
Copy link
Collaborator

Can you share which device you are using?

@hatemragab
Copy link
Author

i have try it in some of android devices like Poco f3 and Samsung

@ujas-m-simformsolutions ujas-m-simformsolutions added the in triage The issue is being triaged label Mar 1, 2023
@ujas-m-simformsolutions
Copy link
Collaborator

ujas-m-simformsolutions commented Mar 2, 2023

From initial comment it looks like stop function is not working but I am not being able to reproduce this. If anyone can share reproducible steps and full error logs then we might able fix this.

@hatemragab
Copy link
Author

Ok i will share example

linchen00 added a commit to GoodNewsLabs/audio_waveforms that referenced this issue Mar 3, 2023
@NiklasFoP
Copy link

NiklasFoP commented Mar 4, 2023

I have the same issue that it throws "Failed stop recording". It works only after rebuilding the app once and then never again. Hot refresh and restart doesn't work. The app has to be rebuild from scratch then it works one time and only one time...Can we fix that?

@NiklasFoP
Copy link

NiklasFoP commented Mar 4, 2023

Here's some more information on the error: E/CheckPermission(32117): media_record-code= 1
D/MediaRecorder(32117): Release X 0xb40....
D/MediaRecorder(32117): destructor E 0xb40...
D/MediaRecorder(32117): destructor X 0xb400...
E/AudioWaveforms(32117): Failed to stop recording

When I go out of the widget by navigating in the app I get this among a lot of other messages that keep repeating and won't stop:
This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().

@AppetiteTeam
Copy link

same

@ujas-m-simformsolutions ujas-m-simformsolutions added bug Something isn't working and removed in triage The issue is being triaged labels Mar 6, 2023
@ujas-m-simformsolutions
Copy link
Collaborator

Thank you @NiklasFoP, I can reproduce the issue now.

@ujas-m-simformsolutions ujas-m-simformsolutions linked a pull request Mar 6, 2023 that will close this issue
ujas-m-simformsolutions pushed a commit that referenced this issue Mar 6, 2023
* fix:Failed to stop recording #163

* fix:invoke stopRecord method return previous path
@ujas-m-simformsolutions
Copy link
Collaborator

We have released 1.0.3 with a fix for this. If anyone still faces the issue please file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants