update return type of result when user stop the audio player #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Mar 14, 2024
| final audioInfo = | ||
| await _methodChannel.invokeMethod(Constants.stopRecording); | ||
| return List.from(audioInfo ?? []); | ||
| Future<Map<String,dynamic>> stop() async { |
There was a problem hiding this comment.
File looks unformatted
|
Also please bump the version and update changelog mentioning minor internal restructure and mention breaking change of previous PR. |
himanshuGandhiSimform
force-pushed
the
update_native_data_return_type
branch
from
1c751ec to
5aff7e3
Compare
hemantbeast
added a commit
to hemantbeast/audio_waveforms
that referenced
this pull request
May 28, 2024
… when user stop the audio player
himanshuGandhiSimform
force-pushed
the
update_native_data_return_type
branch
2 times, most recently
from
d752903 to
06e27ca
Compare
ujas-m-simformsolutions
requested changes
Nov 26, 2024
Comment on lines
317
to
318
| if (audioInfo[Constants.resultDuration] != null) { | ||
| var duration = audioInfo[Constants.resultDuration]; |
There was a problem hiding this comment.
Suggested change
| if (audioInfo[Constants.resultDuration] != null) { | |
| var duration = audioInfo[Constants.resultDuration]; | |
| final duration = audioInfo[Constants.resultDuration]; | |
| if(duration != null) { | |
| ... | |
| } |
android/src/main/kotlin/com/simform/audio_waveforms/AudioRecorder.kt
Outdated
Show resolved
Hide resolved
himanshuGandhiSimform
force-pushed
the
update_native_data_return_type
branch
from
06e27ca to
df3a36f
Compare
ujas-m-simformsolutions
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update return type of data from native to flutter