🩹 bugfix - 350 - Waveform clipping at starting position #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/audio_waveforms.dart
Outdated
| @@ -41,7 +41,7 @@ class _AudioWaveformsState extends State<AudioWaveforms> { | |||
| Offset _dragOffset = Offset.zero; | |||
|
|
|||
| double _initialOffsetPosition = 0.0; | |||
| double _initialPosition = 0.0; | |||
| double _initialPosition = 3.0; | |||
There was a problem hiding this comment.
Dont use static values. What if I set waveThickness too large wouldn't the wave get outside of the viewport?
jay-simformsolutions
force-pushed
the
fix/350/waveform_clipping_at_start
branch
2 times, most recently
from
78d7d3c to
7fc3bd4
Compare
jay-simformsolutions
force-pushed
the
fix/350/waveform_clipping_at_start
branch
from
7fc3bd4 to
a5217c1
Compare
ujas-m-simformsolutions
approved these changes
Oct 28, 2024
ujas-m-simformsolutions
deleted the
fix/350/waveform_clipping_at_start
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #350