Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New credit card brands (Elo/Hipercard) and icons was added. #109

Merged

Conversation

tceccatto
Copy link
Contributor

Hi everyone.

Thanks for the library. It's awesome!

We miss the Elo and Hipercard card brands, so I created this pull request to add them.

This pr add Elo and Hipercard brands to the Credit Card Widget.

@ShwetaChauhan18
Copy link
Contributor

Thanks @tceccatto for your contribution
We will check and let you know

@tceccatto tceccatto closed this Oct 13, 2022
@tceccatto tceccatto reopened this Oct 13, 2022
@tceccatto
Copy link
Contributor Author

Thanks for the approval @ShwetaChauhan18

When a new version of the library will be generated?

@ShwetaChauhan18
Copy link
Contributor

Thanks for the approval @ShwetaChauhan18

When a new version of the library will be generated?

@tceccatto: We are working on scan feature so, once it's complete we will release new one

@shwetachauhan-simform shwetachauhan-simform merged commit ff01618 into SimformSolutionsPvtLtd:master Oct 20, 2022
@ShwetaChauhan18
Copy link
Contributor

@tceccatto : Can you please add this feature change in changelog.md file and create 1 PR

@tceccatto tceccatto deleted the new-brands branch October 25, 2022 19:24
@tceccatto
Copy link
Contributor Author

@ShwetaChauhan18 : it's done: #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants