fix: 🐛 Take in account view insets (such as keyboard) #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take in account the view insets of the device, such as the keyboard that is up, so that we can correctly determine if the widget should be on top or below. If you're trying to highlight something that is at the bottom of the screen and the keyboard is up, it will try to render it below the widget, which would be under the keyboard. By taking in account view insets we can assure that widgets that are sticky to the bottom get correctly highlighted when the keyboard is up. To test this all you need to do is make a widget sticky to the bottom of your screen, summon the keyboard and then showcase the sticky widget. You'll see that everything is blacked out except the sticky widget, but the arrow and text message will be invisible as it's below the keyboard.
DhvanitVaghani
approved these changes
Jan 3, 2023
|
Hi @Cellaryllis Could you please resolve conflicts for this PR ? |
faiyaz-shaikh
added a commit
that referenced
this pull request
Jan 30, 2023
7 tasks
faiyaz-shaikh
added a commit
that referenced
this pull request
Jan 30, 2023
faiyaz-shaikh
added a commit
that referenced
this pull request
Jan 30, 2023
faiyaz-shaikh
changed the title
faiyaz-shaikh
force-pushed
the
patch-1
branch
2 times, most recently
from
eb49140 to
3b69de6
Compare
faiyaz-shaikh
force-pushed
the
patch-1
branch
from
3b69de6 to
e543d6d
Compare
7 tasks
satria-wardana
added a commit
to satria-wardana/flutter_showcaseview
that referenced
this pull request
Sep 7, 2023
* master: (55 commits) 📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368) feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359) fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361) ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356) fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351) fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353) 🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341) fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288) Miscellaneous changes Add missing copyright notice in enum.dart feat: ✨ Add padding to title and description fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322) feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306) feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319) ✨ add mac support in example. (SimformSolutionsPvtLtd#197) Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321) chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286) release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302) release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301) fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300) ... # Conflicts: # example/ios/Flutter/AppFrameworkInfo.plist # example/ios/Runner.xcodeproj/project.pbxproj # example/lib/main.dart # lib/src/showcase.dart # lib/src/showcase_widget.dart # lib/src/tooltip_widget.dart
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_showcaseview
that referenced
this pull request
Oct 28, 2023
…nsPvtLtd#288) * Take in account view insets (such as keyboard) Take in account the view insets of the device, such as the keyboard that is up, so that we can correctly determine if the widget should be on top or below. If you're trying to highlight something that is at the bottom of the screen and the keyboard is up, it will try to render it below the widget, which would be under the keyboard. By taking in account view insets we can assure that widgets that are sticky to the bottom get correctly highlighted when the keyboard is up. To test this all you need to do is make a widget sticky to the bottom of your screen, summon the keyboard and then showcase the sticky widget. You'll see that everything is blacked out except the sticky widget, but the arrow and text message will be invisible as it's below the keyboard. * Removed warning and analyzer error --------- Co-authored-by: faiyaz-shaikh <89002539+faiyaz-shaikh@users.noreply.github.com> Co-authored-by: faiyaz <faiyaz.s@simformsolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take in account the view insets of the device, such as the keyboard that is up, so that we can correctly determine if the widget should be on top or below. If you're trying to highlight something that is at the bottom of the screen and the keyboard is up, it will try to render it below the widget, which would be under the keyboard.
By taking in account view insets we can assure that widgets that are sticky to the bottom get correctly highlighted when the keyboard is up.
To test this all you need to do is make a widget sticky to the bottom of your screen, summon the keyboard and then showcase the sticky widget. You'll see that everything is blacked out except the sticky widget, but the arrow and text message will be invisible as it's below the keyboard.