Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Fixed ToolTip Slide Transition #369

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: 🐛 Fixed ToolTip Slide Transition #369

merged 1 commit into from
Apr 18, 2024

Conversation

faiyaz-shaikh
Copy link
Contributor

@faiyaz-shaikh faiyaz-shaikh commented Apr 6, 2023 •
edited by Sahil-Simform
Loading

Description

Fixed ToolTip Slide Transition

  • Added toolTipSlideEndDistance to define motion range for tooltip slide animation.
  • Added the ToolTipSlideTransition widget and removed SlideTransition to fix the sliding range issue because before sliding range increased as child's size increased

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

ujas-m-simformsolutions
ujas-m-simformsolutions requested changes Apr 7, 2023
View reviewed changes
lib/src/tooltip_widget.dart Outdated
@@ -589,3 +590,18 @@ class _Arrow extends CustomPainter {
oldDelegate.strokeWidth != strokeWidth;
}
}

class ToolTipSlideTransition extends AnimatedWidget {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is getting very big now, can you please saparate code in multiple files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@faiyaz-shaikh faiyaz-shaikh force-pushed the fix/tooltip_slide_transition branch from 92e21f5 to 06b81e4 Compare April 7, 2023 09:40
ujas-m-simformsolutions
ujas-m-simformsolutions requested changes Apr 12, 2023
View reviewed changes
lib/src/tooltip_widget.dart Outdated
: const Offset(0.0, 0.100),
begin: const Offset(0.0, 0.0),
end: Offset(
0.0, widget.movingEndDistance * contentOffsetMultiplier),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lib/src/tooltip_widget.dart Outdated
top: paddingTop,
),
padding:
EdgeInsets.only(top: paddingTop, bottom: paddingBottom),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@faiyaz-shaikh faiyaz-shaikh force-pushed the fix/tooltip_slide_transition branch from 06b81e4 to 668338a Compare April 13, 2023 07:30
Sahil-Simform
Sahil-Simform requested changes Mar 8, 2024
View reviewed changes
lib/src/tooltip_widget.dart Outdated
end: const Offset(0.0, 0.100),
begin: const Offset(0.0, 0.0),
end: Offset(
0.0, widget.movingEndDistance * contentOffsetMultiplier),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat this for better readability

@Sahil-Simform Sahil-Simform force-pushed the fix/tooltip_slide_transition branch 2 times, most recently from 64f8423 to 4ef1d97 Compare March 8, 2024 12:44
aditya-css
aditya-css requested changes Mar 8, 2024
View reviewed changes
lib/src/showcase.dart Outdated
@@ -247,6 +247,13 @@ class Showcase extends StatefulWidget {
/// Disables barrier interaction for a particular showCase.
final bool disableBarrierInteraction;

/// Define End distance of tooltip position when tooltip is moving.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve wording.

lib/src/showcase.dart Outdated
@@ -247,6 +247,13 @@ class Showcase extends StatefulWidget {
/// Disables barrier interaction for a particular showCase.
final bool disableBarrierInteraction;

/// Define End distance of tooltip position when tooltip is moving.
///
/// Which is from 0 to movingEndDistance (positive)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention it as the motion range for tooltip slide animation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since it is mentioned positive here, please check with negative value and add assertion of the polarity if positive value is absolutely required.

lib/src/showcase.dart Outdated
@@ -292,6 +299,7 @@ class Showcase extends StatefulWidget {
this.descriptionTextDirection,
this.onBarrierClick,
this.disableBarrierInteraction = false,
this.toolTipSlideEndDistance = 7.0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can omit the .0.

lib/src/tooltip_widget.dart Outdated
end: !widget.showArrow && !isArrowUp
? const Offset(0.0, 0.0)
: const Offset(0.0, 0.100),
begin: const Offset(0.0, 0.0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Offset.zero here.

lib/src/widget/tooltip_slide_transition.dart Outdated

@override
Widget build(BuildContext context) =>
Transform.translate(offset: _progress.value, child: child);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve format for better readability.

lib/src/widget/tooltip_slide_transition.dart Outdated

final Widget child;

Animation<Offset> get _progress => listenable as Animation<Offset>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this variable is only used in the build method, you can create it there only instead of this getter.

@Sahil-Simform Sahil-Simform force-pushed the fix/tooltip_slide_transition branch 7 times, most recently from e76f490 to abdcd00 Compare March 12, 2024 07:00
@aditya-css aditya-css force-pushed the fix/tooltip_slide_transition branch from abdcd00 to 9cc8ebe Compare April 18, 2024 09:12
Ujas-Majithiya
Ujas-Majithiya approved these changes Apr 18, 2024
View reviewed changes
Copy link

@Ujas-Majithiya Ujas-Majithiya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sahil-Simform
Sahil-Simform approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Sahil-Simform Sahil-Simform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ujas-m-simformsolutions
ujas-m-simformsolutions approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faiyaz-shaikh @aditya-css
fix: 🐛 Fixed ToolTip Slide Transition
ca27e7f 
- Added `toolTipSlideEndDistance` to define motion range for tooltip slide animation.
- Added `ToolTipSlideTransition` widget and removed `SlideTransition` to fix sliding range issue because before sliding range is increasing as child's size increase
@aditya-css aditya-css force-pushed the fix/tooltip_slide_transition branch from 9cc8ebe to ca27e7f Compare April 18, 2024 09:28
@aditya-css aditya-css merged commit 6ed6e03 into master Apr 18, 2024
2 checks passed
@aditya-css aditya-css deleted the fix/tooltip_slide_transition branch April 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahil-Simform Sahil-Simform Sahil-Simform approved these changes

@aditya-css aditya-css aditya-css approved these changes

@ujas-m-simformsolutions ujas-m-simformsolutions ujas-m-simformsolutions approved these changes

@Ujas-Majithiya Ujas-Majithiya Ujas-Majithiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faiyaz-shaikh @Ujas-Majithiya @ujas-m-simformsolutions @aditya-css @Sahil-Simform