Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ⚡ Improved showCaseWidgetState variable in Showcase class #413

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Sahil-Simform
Copy link
Collaborator

  • Improved showCaseWidgetState variable in Showcase class by removing getter as getter will compute that variable every time thus reducing performance
  • Updated CHANGELOG.md

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@Sahil-Simform Sahil-Simform force-pushed the fix/improved_variable_managment branch from 59faa4d to a406268 Compare March 11, 2024 10:58
@Sahil-Simform Sahil-Simform changed the title Fix: ⚡ Improved showCaseWidgetState variable in Showcase class fix: ⚡ Improved showCaseWidgetState variable in Showcase class Mar 11, 2024
- Improved `showCaseWidgetState` variable in `Showcase` class by removing getter as getter will compute that variable every time thus reducing performance
- Updated `CHANGELOG.md`
@Sahil-Simform Sahil-Simform force-pushed the fix/improved_variable_managment branch from a406268 to 89fd106 Compare March 11, 2024 11:01
@aditya-css aditya-css merged commit fdb6e06 into master Apr 18, 2024
2 checks passed
@aditya-css aditya-css deleted the fix/improved_variable_managment branch April 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants