Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billions Must Flip #1318

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Dec 6, 2024

Description

Billions must flip.

Goob-Station/Goob-Station#828
Goob-Station/Goob-Station#832

Changelog

🆑

  • add: Spin, flip, and jump emotes have been added.

whateverusername0 and others added 2 commits December 6, 2024 06:55
* fine shot mate

* forgot datadefs

* forgot partial LOL

---------

Co-authored-by: whateverusername0 <whateveremail>
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 6, 2024
@SimpleStation14 SimpleStation14 changed the title Billions must flip Billions Must Flip Dec 6, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Dec 6, 2024
@sleepyyapril sleepyyapril added Priority: 4-Low Should be resolved at some point Type: Port Brings something to here from another codebase labels Dec 6, 2024
@sleepyyapril sleepyyapril added the Size: 4-Small For small issues/PRs label Dec 6, 2024
Copy link
Contributor

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy

Resources/Prototypes/Actions/emotes.yml Outdated Show resolved Hide resolved
Comment on lines 57 to 58
- type: OwnInteractionVerbs
allowedVerbs: [] # TODO: define something here, or don't.
Copy link
Contributor

@Mnemotechnician Mnemotechnician Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should belong to BaseMob as it always did. This allows all mobs to use interaction verbs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the point, yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not the point, you nuked interaction verbs on all mobs by doing that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's crazy

Signed-off-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
@sleepyyapril
Copy link
Contributor Author

Just to be clear: mobs being able to flip is intentional.

@VMSolidus VMSolidus merged commit 0ed26ce into Simple-Station:master Dec 11, 2024
10 of 11 checks passed
sleepyyapril pushed a commit to angelofallars/Einstein-Engines that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants