-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pistol-Whipping (Guns as Melee Weapons) #1335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melee thrust animations now uses the proper rotation for the items
TODO: replace melee angles with long guns with a buttstroke TODO: maybe add stamina cost (minimal)
Melee cooldown after shooting eliminated completely (like Overwatch/Deadlock/Marvel Rivals) Shooting cooldown after melee set to 0.528 seconds regardless of melee attack rate
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Changes: Localization
Changes any ftl files
labels
Dec 11, 2024
VMSolidus
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah.
sleepyyapril
approved these changes
Dec 11, 2024
angelofallars
force-pushed
the
pistol-whip
branch
from
December 11, 2024 23:08
e4710c3
to
08b0647
Compare
Fixed 08b0647 |
IVAN, WORRY NOT, WHEN OUT OF BOOLET, USE MOSIN AS JAVELIN |
DEATHB4DEFEAT
pushed a commit
to DEATHB4DEFEAT/Einstein-Engines
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to use guns as melee weapons and throwing weapons.
The gun melee attack is a Light Attack done with a right click. The attack rate is slower than average melee weapons.
The cooldown on melee attacks after shooting has been removed entirely, so you can right-click immediately after shooting (like in hero shooters 😎). The cooldown on shooting after a melee attack has been set to a constant 0.5 seconds.
Balance
Technically speaking, weaving shooting and pistol-whipping lowers your overall DPS in most cases, because you can't shoot for 0.5 seconds after doing a melee attack. With skillful usage, however, it provides some key tactical advantages:
Pistol-whipping also helps as a last resort when you run out of ammo. However, it's almost always better to use a proper melee weapon instead of a gun as a pure melee weapon, because you can't power attack with guns and the guns' melee attack rate are slower by design than most melee weapons.
Shotguns benefit the most from pistol-whipping, because their ideal range is close-range where a melee attack can be performed, and their low fire rate means they're not affected too much by the 0.5s shooting cooldown.
Guns have received throwing damage. You can throw guns at the enemy once you're out of ammo to deal extra damage. I think this makes fights a little more spectacular to watch.
Melee damage sorted by group (from least to greatest):
Media
mk 58
Kardashev-Mosin (Wielded)
Basic Combat
video-2024-12-12_02.21.mp4
Particle Decelerator Combo (80 damage)
video-2024-12-12_06.13.mp4
Combo: Shoot + Power Attack, wait 1.6s then Power Attack + Throw
This combo costs 90 stamina which almost depletes 100 stamina leaving you vulnerable, so the Vigor trait can help you pull off this combo.
Changelog
🆑 Skubman