-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass Contests Remake #480
Mass Contests Remake #480
Conversation
Does this PR rely on 458? |
This does not requires 458, but it is related to 458. Adding mass contests is primarily a method of helping to provide new game-play variety for characters whose mass is modified by height sliders. But, it doesn't require it in the sense that if we merge this but not height sliders, it will still function completely as is as its own standalone system. You would get to experience it as differences by Felinids, Harpies, Oni, and Diona. |
I have fixed the sole bug reported by Deep Station 14's playtest, that of handcuffs not working correctly. They are now working as intended, and there is now a small switch allowing handcuffs and zipties to have opposite interactions with massContest. Handcuffs are now correctly set to be easier to escape if you are smaller. While Zipties are instead easier to escape if you are larger. |
@DEATHB4DEFEAT @Pspritechologist @Peptide90 @OldDanceJacket |
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncuffMassMultiplies is a tiny bit unclear from the name alone so add two comments as needed
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
…nstein-Engines into MassContests-Remake
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Description
Part of Issue #467
This is a complete re imagining of the Nyanotrasen Mass Contest System(Long since removed from the game). This system adds a highly flexible function that outputs a ratio of a given entity's mass, that is optionally relative to another entity. I've primarily written this system to be used in conjunction with PR #458 , as it adds several new implementations of variable player mass to the game.
How this differs from the original Mass Contest system is that it is configured via hotloaded CVars, and is inherently clamped so that character mass only modifies functions by a finite amount rather than providing infinite scaling. This essentially means that while an Oni is 25% better at shoving a Felinid to the floor thanks to their different masses, a 2000kg Lamia is also only 25% better at shoving a Felinid to the floor, rather than 50000% better. The inverse is also true, a small player character can only be 25% better or worse at a given implementation. These implementations are not handled directly by the ContestSystem, and are instead handled directly by other systems that call upon it.
This percentage limit can be modified by a new CVar at any time. Additionally, the entire MassContest system can be optionally toggled off completely at any time via CVar, without needing to modify any code that calls upon it.
At this time, I have included three different implementations to serve as suitable examples for how MassContest can be used.
Changelog
🆑