Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Harpy Abilities & Traits #768

Closed
wants to merge 18 commits into from

Conversation

gluesniffler
Copy link
Contributor

@gluesniffler gluesniffler commented Aug 21, 2024

Description

Draft PR for birbs! Since their main unique ability was given as a trait to everyone (albeit in a watered down version as per #714), we might as well get them something new. And with our new and shiny traits/mood systems it seems like a perfect opportunity to do some new work!

The tentative new features can be found in this quasi-design/lore document, https://hackmd.io/5InmzXlOQc-AG7KSKoW1Nw

Just opening this PR up as draft to gather feedback and keep myself accountable

9/16 Update: Currently on hold as I'm working on Shitmed, do poke me if you want me to finish DashSystem or something.


TODO

  • Create a generic flying system that can be used for harpies
  • Modify stamina system to add persistent drains for stamina (to be used in flying)
  • Do animation work with visualizers to make it look extra snazzy (need to harass @VMSolidus to separate harpy wing markings for an improved version of this)
  • Create a Dash System that can displace an entity to a given location (kinda done? needs polish)
  • Figure out conditionals and other edge cases with Dash System (will entities phase through walls accidentally or just take collision damage)
  • Adjust Dash System for a short, targeted harpy flight.
  • Make Dash System into a generic system that can take a custom sound effect for the dash, along with other goodies such as optional custom visualizers, damage properties, collision effects, etc.
  • Make a generic system for storing colors of things based off a given entity's hair/body. This component should be passed on as well to relevant recipes that need it (feathers with a color of #FF0000 should make head decor that also carry this color somehow).
  • Add the preening system to get feathers or husks. TBD if its gonna work off a timer, stacks, chance, or a mix of all 3.
  • Add "feathercraft" recipes to construction. (Tentative ideas are a feather head decor, a hat with feather, feather pen, coat with feather decorations, feather fan, pillow, feather dagger, feather knife fan, and feather spear)
  • Lock relevant abilities behind traits
  • Move shit out of the dv harpy namespace lmao
  • harpies real

Media

patthebirb


Changelog

🆑

  • add: Added birbs :D
  • tweak: Tweaked birbs

@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

RSI Diff Bot; head commit 7faa3ee merging into 88451f1
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/flight.rsi

State Old New Status
flight_off Added
flight_on Added

Edit: diff updated after 7faa3ee

@gluesniffler
Copy link
Contributor Author

For whatever reason when I created this branch there was stuff from the hardsuits changes, I removed them but solidus was still added as a participant :trollface:

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 30, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 12, 2024
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gluesniffler
Copy link
Contributor Author

Given my current ongoing work on shitmed, I doubt I'll get to finish this anytime soon, probably will pick it back up after the new year with learnings from the shitcode galore.

Hopefully I'll get preening system done when I get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants