Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 More Traits #918

Merged
merged 10 commits into from
Sep 17, 2024
Merged

9 More Traits #918

merged 10 commits into from
Sep 17, 2024

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Sep 14, 2024

Description

This "ZERO C#" Pr adds 10 additional traits to the game, which only make use of pre-existing components, along with some of the new TraitSystem functionality. These are the following new traits:

  • Photophobia: Functions as per Vulpkanin Light Sensitivity
  • Clumsy: Functions as per Clown clumsiness
  • Small: Functions as per Felinid PseudoItem, requires a character be Felinid sized
  • Temperature Tolerance: Functions as per Vulpkanin low temperature resistance
  • Spinarette: Functions as per the same ability from Arachnids.
  • Talons: Replaces your melee natural attacks with Piercing talons
  • Claws: Replaces your melee natural attacks with Slashing claws
  • Striking Calluses: [Human only, requires Martial Artist or Boxer job], increases your base unarmed attack to 6 damage, from 5.
  • Natural Weapon Removal: For species with melee attacks other than blunt, replaces Talons or Claws with Fist.

TODO:

  • Adjust the points costs/additions for these traits to ensure balance. Although I can't imagine most of them being changed. I do still wish for a decent number of traits to be within the 1 to 3 point range.

Media

image

image

Changelog

🆑

  • add: 10 new Traits have been added to the game. Photophobia, Clumsy, Small, Temperature Tolerance, Claws, Talons, Natural Weapon Removal, Striking Calluses, and Spinarette.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Sep 14, 2024
Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not approving but not request changing as those feels more like its for a "custom specie" slot then the rest.

In all honest some trait should be removed and kept for those species but, huh maybe that is just my personnal opinion.

But personnaly i would not give the claws, talon, spider trait to random species unless making a custom specie system.

Resources/Prototypes/Traits/physical.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Traits/physical.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Traits/physical.yml Show resolved Hide resolved
Resources/Prototypes/Traits/physical.yml Outdated Show resolved Hide resolved
@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this labels Sep 14, 2024
@VMSolidus
Copy link
Member Author

not approving but not request changing as those feels more like its for a "custom specie" slot then the rest.

In all honest some trait should be removed and kept for those species but, huh maybe that is just my personnal opinion.

But personnaly i would not give the claws, talon, spider trait to random species unless making a custom specie system.

This is the custom species system. Buy a shitton of "Mutation" traits, and DIY. You're welcome.

@FoxxoTrystan FoxxoTrystan added Size: 4-Small For small issues/PRs and removed Size: 5-Very Small For especially small issues/PRs labels Sep 14, 2024
@FoxxoTrystan
Copy link
Member

"Tiny"

not approving but not request changing as those feels more like its for a "custom specie" slot then the rest.
In all honest some trait should be removed and kept for those species but, huh maybe that is just my personnal opinion.
But personnaly i would not give the claws, talon, spider trait to random species unless making a custom specie system.

This is the custom species system. Buy a shitton of "Mutation" traits, and DIY. You're welcome.

Ehh... personnaly for custom species system i would like to give servers a CVar to see if they want that enable or at least... hm...
Well fine i supose.

@FoxxoTrystan
Copy link
Member

Personnally i feel this would cause a mess.
And its feels a bit detached.

But i wana get others peoples opinion on it first before i approve it.

@FoxxoTrystan FoxxoTrystan self-requested a review September 14, 2024 05:39
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
@OldDanceJacket
Copy link
Contributor

Personnally i feel this would cause a mess. And its feels a bit detached.

But i wana get others peoples opinion on it first before i approve it.

Tagging in to review, I agree with the thoughts shared here. Turning players into Items has a lot of actual implications I don't like and I'd just like that one day you can put anyone in the deep-fryer regardless(I know there's more things possible but using that example). Small is 'okay' but I genuinely don't like the range of height and weight the sliders can currently go in the first place and have had a few other folks speak up about how thin and short you can make folks is a bit much.

Realistically I'd say get rid of Tiny, Talons, Claws, and Spinarette.

This is genetic weirdness that shouldn't be round start and is really against a lot of the vibes of SpaceStation.

The other traits are fine, Temperature Tolerance is a real thing I actually met a guy who would work in the walk in freezer shirtless just moving boxes from the truck.

@FoxxoTrystan
Copy link
Member

FoxxoTrystan commented Sep 14, 2024

image

Resources/Locale/en-US/traits/traits.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/traits/traits.ftl Outdated Show resolved Hide resolved
Resources/Prototypes/Traits/physical.yml Show resolved Hide resolved
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title 8 More Traits 6 More Traits Sep 14, 2024
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
@VMSolidus
Copy link
Member Author

Personnally i feel this would cause a mess. And its feels a bit detached.
But i wana get others peoples opinion on it first before i approve it.

Tagging in to review, I agree with the thoughts shared here. Turning players into Items has a lot of actual implications I don't like and I'd just like that one day you can put anyone in the deep-fryer regardless(I know there's more things possible but using that example). Small is 'okay' but I genuinely don't like the range of height and weight the sliders can currently go in the first place and have had a few other folks speak up about how thin and short you can make folks is a bit much.

Realistically I'd say get rid of Tiny, Talons, Claws, and Spinarette.

This is genetic weirdness that shouldn't be round start and is really against a lot of the vibes of SpaceStation.

The other traits are fine, Temperature Tolerance is a real thing I actually met a guy who would work in the walk in freezer shirtless just moving boxes from the truck.

"This is genetic weirdness that shouldn't be round start and is really against a lot of the vibes of SpaceStation."
"Doesn't go with the vibes of SS13"
Okay. Absolutely not. In the case of bionic spinarette, this is literally a trait lifted directly 1:1 from SS13. You absolutely can be wrong about some things, and this is one of those. Also NEITHER of the small or tiny traits have anything at all to do with modifying your height sliders, they merely ask for your height slider bounds as a requirement. Which, I should remind you, I intentionally selected 1:1 X and Y scale limitations specifically so that you aren't being a "Lankly" character to minmax with the trait.

Hell I'm half tempted to put back claws and talons, because those are also shit you can just fucking do in SS13.
image

Behold, a whole goddamn bionics menu. I would fucking love to have something like this one day, and in that time, remove the traits and move them to the bionics menu.

@VMSolidus
Copy link
Member Author

Right, so I'm surprised that Drunk Solidus can do YML just fine, but his writing is dogshit. So I'm not only doubling down on this PR, but I'm also substantially increasing the quality and depth of the trait descriptions.

image

@VMSolidus VMSolidus changed the title 6 More Traits 10 More Traits Sep 14, 2024
@OldDanceJacket
Copy link
Contributor

Personnally i feel this would cause a mess. And its feels a bit detached.
But i wana get others peoples opinion on it first before i approve it.

Tagging in to review, I agree with the thoughts shared here. Turning players into Items has a lot of actual implications I don't like and I'd just like that one day you can put anyone in the deep-fryer regardless(I know there's more things possible but using that example). Small is 'okay' but I genuinely don't like the range of height and weight the sliders can currently go in the first place and have had a few other folks speak up about how thin and short you can make folks is a bit much.
Realistically I'd say get rid of Tiny, Talons, Claws, and Spinarette.
This is genetic weirdness that shouldn't be round start and is really against a lot of the vibes of SpaceStation.
The other traits are fine, Temperature Tolerance is a real thing I actually met a guy who would work in the walk in freezer shirtless just moving boxes from the truck.

"This is genetic weirdness that shouldn't be round start and is really against a lot of the vibes of SpaceStation." "Doesn't go with the vibes of SS13" Okay. Absolutely not. In the case of bionic spinarette, this is literally a trait lifted directly 1:1 from SS13. You absolutely can be wrong about some things, and this is one of those. Also NEITHER of the small or tiny traits have anything at all to do with modifying your height sliders, they merely ask for your height slider bounds as a requirement. Which, I should remind you, I intentionally selected 1:1 X and Y scale limitations specifically so that you aren't being a "Lankly" character to minmax with the trait.

Hell I'm half tempted to put back claws and talons, because those are also shit you can just fucking do in SS13. image

Behold, a whole goddamn bionics menu. I would fucking love to have something like this one day, and in that time, remove the traits and move them to the bionics menu.

It doesn't fit the vibes, doesn't matter if some forks put it in or not, I'm giving my opinion.

Secondly the height/weights were a minor point, I don't care about the minmax attempts of it(small and weird as that is), I care that the Tiny trait and the implications it brings as well as the round start gameplay it gives to the players is inherently just toxic and I dislike it a bunch.
I told you in DMs when you were drunk that beyond all of the other additions you want to make this one is the one I have the most problems with and frankly it's just dumb. There doesn't need to be a trait like this in the game.

@VMSolidus VMSolidus changed the title 10 More Traits 9 More Traits Sep 16, 2024
Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont hate this

species:
- Felinid # Felinids already have cat claws.
- Reptilian # Reptilians also have cat claws.
# - Vulpkanin # Vulpkanin have "Blunt" claws. One could argue this trait "Sharpens" their claws.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they do? time to fix it later and then cchange it here.

@VMSolidus VMSolidus merged commit f5275e2 into Simple-Station:master Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants