Skip to content

Commit

Permalink
Fix for loading markdown pages with spaces in the name (withastro#3379)
Browse files Browse the repository at this point in the history
* Fix for loading markdown pages with spaces in the name

* Adds a changeset
  • Loading branch information
matthewp authored May 16, 2022
1 parent e24b215 commit 534c521
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 9 deletions.
8 changes: 5 additions & 3 deletions src/vite-plugin-markdown/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import type { Plugin } from 'vite';
import type { AstroConfig } from '../@types/astro';
import { PAGE_SSR_SCRIPT_ID } from '../vite-plugin-scripts/index.js';
import { pagesVirtualModuleId } from '../core/app/index.js';
import { appendForwardSlash } from '../core/path.js';
import { resolvePages } from '../core/util.js';
import { appendForwardSlash, prependForwardSlash } from '../core/path.js';
import { resolvePages, viteID } from '../core/util.js';

interface AstroPluginOptions {
config: AstroConfig;
Expand Down Expand Up @@ -156,7 +156,9 @@ ${setup}`.trim();
site: config.site ? new URL(config.base, config.site).toString() : undefined,
sourcefile: id,
sourcemap: 'inline',
internalURL: `/@fs${new URL('../runtime/server/index.js', import.meta.url).pathname}`,
internalURL: `/@fs${prependForwardSlash(
viteID(new URL('../runtime/server/index.js', import.meta.url))
)}`,
});

tsResult = `\nexport const metadata = ${JSON.stringify(metadata)};
Expand Down
39 changes: 33 additions & 6 deletions test/astro-pages.test.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,46 @@
import { expect } from 'chai';
import * as cheerio from 'cheerio';
import { loadFixture } from './test-utils.js';
import { loadFixture, isWindows} from './test-utils.js';

describe('Pages', () => {
let fixture;

before(async () => {
fixture = await loadFixture({ root: './fixtures/astro-pages/' });
fixture = await loadFixture({ root: './fixtures/astro pages/' });
await fixture.build();
});

it('Can find page with "index" at the end file name', async () => {
const html = await fixture.readFile('/posts/name-with-index/index.html');
const $ = cheerio.load(html);
describe('Build', () => {
before(async () => {
await fixture.build();
});

expect($('h1').text()).to.equal('Name with index');
it('Can find page with "index" at the end file name', async () => {
const html = await fixture.readFile('/posts/name-with-index/index.html');
const $ = cheerio.load(html);

expect($('h1').text()).to.equal('Name with index');
});
});

if(isWindows) return;

describe('Development', () => {
let devServer;

before(async () => {
devServer = await fixture.startDevServer();
});

after(async () => {
await devServer.stop();
});

it('Is able to load md pages', async () => {
const html = await fixture.fetch('/').then((res) => res.text());
const $ = cheerio.load(html);

expect($('#testing').length).to.be.greaterThan(0);
});
});
});
File renamed without changes.
1 change: 1 addition & 0 deletions test/fixtures/astro pages/src/pages/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Testing

0 comments on commit 534c521

Please sign in to comment.