Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Sitecore Experience Commerce #15

Closed
wants to merge 6 commits into from

Conversation

robearlam
Copy link
Member

Update to the Helix documentation to include Sitecore Experience Commerce.

Copy link

@sc-andrewsutherland sc-andrewsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I correctly added comments.

helix/introduction/definitions.rst Outdated Show resolved Hide resolved
helix/introduction/definitions.rst Outdated Show resolved Hide resolved
helix/principles/architecture-principles/dependencies.rst Outdated Show resolved Hide resolved
helix/principles/architecture-principles/layers.rst Outdated Show resolved Hide resolved
helix/principles/file-structure/modules.rst Outdated Show resolved Hide resolved
helix/principles/subsystems/commerce.rst Outdated Show resolved Hide resolved
helix/principles/subsystems/commerce.rst Outdated Show resolved Hide resolved
helix/principles/subsystems/index.rst Outdated Show resolved Hide resolved
helix/principles/visual-studio/structure.rst Outdated Show resolved Hide resolved
helix/principles/visual-studio/structure.rst Outdated Show resolved Hide resolved
helix/principles/file-structure/modules.rst Outdated Show resolved Hide resolved
helix/principles/architecture-principles/layers.rst Outdated Show resolved Hide resolved
helix/principles/architecture-principles/layers.rst Outdated Show resolved Hide resolved
@@ -62,6 +62,11 @@ should always be in the domain language. (See :doc:`/principles/architecture-pri
The Social feature enables Twitter feeds on the pages as well as
allows the editor to add Facebook metadata to the website pages.

Feature/Cart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually in Habitat, is it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from Sitecore.HabitatHome.Commerce: https://github.com/Sitecore/Sitecore.HabitatHome.Commerce

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ha. this admonition is getting updated in the Helix Examples branch too. Maybe we need a separate admonition section below this w/ an example list of modules from Habitat Home Commerce.

helix/principles/subsystems/index.rst Outdated Show resolved Hide resolved
helix/principles/subsystems/index.rst Outdated Show resolved Hide resolved

Please note that – although confusing – this does not apply to the
Environment definitions that form part of Sitecore Experience Commerce
which should certainly be included in Source Control.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a why here, we Shouldn't just put down that they should be in source control without the reasoning behind it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@@ -62,6 +62,11 @@ should always be in the domain language. (See :doc:`/principles/architecture-pri
The Social feature enables Twitter feeds on the pages as well as
allows the editor to add Facebook metadata to the website pages.

Feature/Cart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from Sitecore.HabitatHome.Commerce: https://github.com/Sitecore/Sitecore.HabitatHome.Commerce

@nickwesselman
Copy link
Contributor

@robearlam I think once we address the two issues that @jameshirka identified, we can finally merge this!

nickwesselman added a commit that referenced this pull request Oct 24, 2019
nickwesselman added a commit that referenced this pull request Oct 24, 2019
[#11] Small updates to Rob's Commerce PR (#15)
@nickwesselman
Copy link
Contributor

Superseded by #36

nickwesselman added a commit that referenced this pull request Oct 24, 2019
* Updated changes based on PR #15
* Some additional tweaks by Nick

(cherry picked from commit 6da03b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants