-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion of Sitecore Experience Commerce #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I correctly added comments.
@@ -62,6 +62,11 @@ should always be in the domain language. (See :doc:`/principles/architecture-pri | |||
The Social feature enables Twitter feeds on the pages as well as | |||
allows the editor to add Facebook metadata to the website pages. | |||
|
|||
Feature/Cart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't actually in Habitat, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from Sitecore.HabitatHome.Commerce: https://github.com/Sitecore/Sitecore.HabitatHome.Commerce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ha. this admonition is getting updated in the Helix Examples branch too. Maybe we need a separate admonition section below this w/ an example list of modules from Habitat Home Commerce.
|
||
Please note that – although confusing – this does not apply to the | ||
Environment definitions that form part of Sitecore Experience Commerce | ||
which should certainly be included in Source Control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a why here, we Shouldn't just put down that they should be in source control without the reasoning behind it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
@@ -62,6 +62,11 @@ should always be in the domain language. (See :doc:`/principles/architecture-pri | |||
The Social feature enables Twitter feeds on the pages as well as | |||
allows the editor to add Facebook metadata to the website pages. | |||
|
|||
Feature/Cart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from Sitecore.HabitatHome.Commerce: https://github.com/Sitecore/Sitecore.HabitatHome.Commerce
@robearlam I think once we address the two issues that @jameshirka identified, we can finally merge this! |
Superseded by #36 |
Update to the Helix documentation to include Sitecore Experience Commerce.