Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data folder (and license.xml) as volume among other #13

Merged
merged 11 commits into from
Mar 27, 2018
Merged

Data folder (and license.xml) as volume among other #13

merged 11 commits into from
Mar 27, 2018

Conversation

Ben-m-s
Copy link
Contributor

@Ben-m-s Ben-m-s commented Mar 26, 2018

Included Changes:

  • Data folder out of Website folder
  • Data folder defined as a volume for persistence and to support license.xml file out of the image
  • Data folder is emptied to support becoming a volume
  • license.xml file is deleted from the image (along with other content in Data folder)
  • Support to make Website folder also a volume (only at debugging time)
  • Demo with VS2017 available soon with support for:
    • Local Website at debugging time (no need for synchronization)
    • Website folder embedded in the image at runtime.
    • Website folder files automatically copied from image to Development environment (if missing) (same as databases).
    • Attach to IIS process from VS2017

Caveats:

  • Website folder has been moved to a different location
  • Only implemented over "Sitecore 9.0.1 rev. 171219" for discussion. Changes to be reproduced in V9.0 if accepted.
  • Not documented yet

@Ben-m-s
Add commands to delete DefaultAppPool
9332ce8
@Ben-m-s
- Create environment varialbe for DataFolder
8d204ca 
- Move DataFolder
- Move Website folder
- Import module WebAdministration
- Remove DefaultAppPool
- Stop removing logs from DataFolder
- Move deletion of logs and temp files to last layer for debugging purposes.
@Ben-m-s
- Simplify DataFolder creation
e6db26f 
- Add DataFolder.config file
- Move deletion of DefaultAppPool to the last layer to avoid building error
- Remove unnecessary "Import-Module WebAdministration" line
@Ben-m-s
Replace constants by environment variables while creating file DataFo…
ad388aa 
…lder.config
@Ben-m-s
Set DataFolder as Volume
6a996c0
@Ben-m-s
Delete SIF logs ASAP for security reasons
c6a3333
@Ben-m-s
Replace white spaces
4f02c7b
@Ben-m-s
Apply to CD the same changes done in the CM
591fe02
@Ben-m-s
Do not delete DefaultAppPool as per "microsoft/aspnet-docker#35"
541a7c6
@Ben-m-s
Merge branch 'develop' into small_improvements
1bffbed
@Ben-m-s
Merge remote-tracking branch 'sitecoreGitHub/develop' into develop
fbc5838
@Ben-m-s
Copy link
Contributor Author

Ben-m-s commented Mar 26, 2018

Pull request with demo: Sitecore/docker-examples#1

@Ben-m-s Ben-m-s mentioned this pull request Mar 26, 2018
Merged
jeanfrancoislarente
jeanfrancoislarente approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@jeanfrancoislarente jeanfrancoislarente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked more closely at this PR and the one in docker-demo. I get it now.

@jeanfrancoislarente jeanfrancoislarente merged commit 5ef1b3a into Sitecore:develop Mar 27, 2018
@pbering pbering mentioned this pull request Apr 4, 2018
Closed
pbering pushed a commit that referenced this pull request Jun 14, 2019
@joostmeijles @pbering
Fix IO.Compression.ZipArchiveMode not found error (#13)
f894fad
pbering added a commit that referenced this pull request Jun 14, 2019
@pbering
aligned with pull #13
102ac1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanfrancoislarente jeanfrancoislarente jeanfrancoislarente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ben-m-s @jeanfrancoislarente