[create-sitecore-jss] Only put FETCH_WITH for SXP template, pass prox…

…yPath to prompt (#1884) * only put FETCH_WITH for SXP template * consider pre-populated proxyAppDestination in prompt
Sitecore · Aug 13, 2024 · 41f0943 · 41f0943
1 parent cb4b955
commit 41f0943
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/packages/create-sitecore-jss/src/initializers/angular-xmcloud/index.ts b/packages/create-sitecore-jss/src/initializers/angular-xmcloud/index.ts
@@ -30,6 +30,7 @@ export default class AngularXmCloudInitializer implements Initializer {
       yes: args.yes,
       destination: args.destination,
       proxyName: 'node-xmcloud-proxy',
+      proxyAppDestination: args.proxyAppDestination,
     };
     const proxyDetails = await inquirer.prompt<ProxyArgs>(proxyPrompts, promptArgs);
     args.proxyAppDestination = proxyDetails.proxyAppDestination;

diff --git a/packages/create-sitecore-jss/src/templates/angular-sxp/.env b/packages/create-sitecore-jss/src/templates/angular-sxp/.env
@@ -0,0 +1,2 @@
+# The way in which layout and dictionary data is fetched from Sitecore
+FETCH_WITH=<%- fetchWith %>
diff --git a/packages/create-sitecore-jss/src/templates/angular/.env b/packages/create-sitecore-jss/src/templates/angular/.env
@@ -25,11 +25,6 @@ GRAPH_QL_ENDPOINT=
 # Uses your `package.json` config `appName` if empty.
 SITECORE_SITE_NAME=
 
-<% if (!locals.xmcloud) { -%>
-# The way in which layout and dictionary data is fetched from Sitecore
-FETCH_WITH=<%- fetchWith %>
-<% } -%>
-
 # Your default app language.
 DEFAULT_LANGUAGE=
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# The way in which layout and dictionary data is fetched from Sitecore
		FETCH_WITH=<%- fetchWith %>