[nextjs][react]The language of the form is changed after clicking the…

… submit button (#1274) * Make `sc_lang` as optional qs parameter * [nextjs][react]The language of the form is changed after clicking the submit button * Revert .test file * Revert classname * Update vmImage version to `ubuntu-latest` * Quick fix for unit tests * fix for sitecore-jss-cli * Apply changes * add transpile-only for rest of unit tests
Sitecore · Dec 23, 2022 · 4dc4ca1 · 4dc4ca1
1 parent b99ff23
commit 4dc4ca1
Show file tree

Hide file tree

Showing 14 changed files with 28 additions and 23 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -32,7 +32,7 @@ pr:
 
 pool:
   # todo: we dgaf what specific version of Linux is installed, is there any way to wildcard the version?
-  vmImage: 'Ubuntu-16.04'
+  vmImage: 'ubuntu-latest'
 
 variables:
   shouldPublish: $[or(eq(variables['Build.SourceBranch'], 'refs/heads/dev'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'))]

diff --git a/packages/sitecore-jss-cli/package.json b/packages/sitecore-jss-cli/package.json
@@ -9,8 +9,8 @@
     "lint": "eslint ./src/**/*.ts",
     "prepublishOnly": "npm run build",
     "jss": "node ./dist/bin/jss.js",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
-    "coverage": "nyc --require ts-node/register npm test"
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-dev-tools/package.json b/packages/sitecore-jss-dev-tools/package.json
@@ -7,9 +7,9 @@
     "watch": "npm run build -- --watch",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-forms/package.json b/packages/sitecore-jss-forms/package.json
@@ -6,9 +6,9 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-manifest/package.json b/packages/sitecore-jss-manifest/package.json
@@ -7,10 +7,10 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
     "generate": "npm run build && node ./dist/bin/manifest generate --files ./src/testData/**/*.sitecore.ts --compilers ts-node/register --appName testApp --outputPath ./sitecore/sitecore-import.json --language en",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-nextjs/package.json b/packages/sitecore-jss-nextjs/package.json
@@ -8,7 +8,7 @@
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
-    "test": "mocha --require ts-node/register --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\"",
+    "test": "mocha --require ts-node/register/transpile-only --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test"
   },

diff --git a/packages/sitecore-jss-proxy/package.json b/packages/sitecore-jss-proxy/package.json
@@ -7,9 +7,9 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-react-forms/package.json b/packages/sitecore-jss-react-forms/package.json
@@ -6,7 +6,7 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
-    "test": "mocha --require ts-node/register --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.tsx\"",
+    "test": "mocha --require ts-node/register/transpile-only --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build"
   },
   "engines": {

diff --git a/packages/sitecore-jss-react-forms/src/components/form.tsx b/packages/sitecore-jss-react-forms/src/components/form.tsx
@@ -23,6 +23,7 @@ export interface ErrorComponentProps {
 
 export interface FormProps {
   form: SitecoreForm;
+  language?: string;
   fieldFactory?: FieldFactory;
   sitecoreApiHost: string;
   sitecoreApiKey: string;
@@ -97,7 +98,11 @@ export class Form extends Component<FormProps, FormState & FieldStateCollection>
       return <div>Form data invalid. Forget to set the rendering contents resolver?</div>;
     }
 
-    const action = `${this.props.sitecoreApiHost}/api/jss/formbuilder?fxb.FormItemId=${form.metadata.itemId}&fxb.HtmlPrefix=${form.htmlPrefix}&sc_apikey=${this.props.sitecoreApiKey}&sc_itemid=${form.contextItemId}`;
+    const action = `${this.props.sitecoreApiHost}/api/jss/formbuilder?fxb.FormItemId=${
+      form.metadata.itemId
+    }&fxb.HtmlPrefix=${form.htmlPrefix}&sc_apikey=${this.props.sitecoreApiKey}&sc_itemid=${
+      form.contextItemId
+    }&sc_lang=${this.props.language || ''}`;
 
     this._tracker.setFormData(
       form.formItemId.value,

diff --git a/packages/sitecore-jss-react/package.json b/packages/sitecore-jss-react/package.json
@@ -6,7 +6,7 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
-    "test": "mocha --require ts-node/register --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\"",
+    "test": "mocha --require ts-node/register/transpile-only --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test"
   },

diff --git a/packages/sitecore-jss-rendering-host/package.json b/packages/sitecore-jss-rendering-host/package.json
@@ -6,9 +6,9 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.10"

diff --git a/packages/sitecore-jss-tracking/package.json b/packages/sitecore-jss-tracking/package.json
@@ -6,9 +6,9 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-jss-update-package/package.json b/packages/sitecore-jss-update-package/package.json
@@ -7,9 +7,9 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"

diff --git a/packages/sitecore-pipelines/package.json b/packages/sitecore-pipelines/package.json
@@ -7,10 +7,10 @@
     "build": "npm run clean && tsc",
     "clean": "del-cli dist types",
     "lint": "eslint ./src/**/*.ts",
-    "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
+    "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\" --exit",
     "prepublishOnly": "npm run build",
     "runner": "npm run build && node ./dist/runner",
-    "coverage": "nyc --require ts-node/register npm test"
+    "coverage": "nyc --require ts-node/register/transpile-only npm test"
   },
   "engines": {
     "node": ">=8.1"