Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more types from sitecore-jss & jss-react #1043

Merged

Conversation

pzi
Copy link
Contributor

@pzi pzi commented May 27, 2022

Export more sitecore-jss and sitecore-jss-react types from within the nextjs package.

Description / Motivation

Fixes #1036

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@pzi pzi force-pushed the feature/export-more-types-from-nextjs branch from a868c38 to f9a58ac Compare May 27, 2022 05:56
@pzi pzi force-pushed the feature/export-more-types-from-nextjs branch from f9a58ac to 35bde3c Compare May 27, 2022 06:09
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor adjustment

packages/sitecore-jss-nextjs/src/index.ts Outdated Show resolved Hide resolved
@pzi pzi requested a review from ambrauer May 29, 2022 04:15
@illiakovalenko illiakovalenko self-requested a review May 31, 2022 11:42
@illiakovalenko illiakovalenko merged commit 32a0acc into Sitecore:dev May 31, 2022
@pzi pzi deleted the feature/export-more-types-from-nextjs branch June 1, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export more types from @sitecore-jss/sitecore-jss-nextjs
5 participants