Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React] App fails to open in Experience Editor/Headless ssr proxy #1136

Merged
merged 2 commits into from
Aug 31, 2022
Merged

[React] App fails to open in Experience Editor/Headless ssr proxy #1136

merged 2 commits into from
Aug 31, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 30, 2022 •
edited
Loading

Description / Motivation

  • Resolves symlink issue for server bundle: 
    Error occurs:
Error Rendering Sitecore.JavaScriptServices.ViewEngine.Presentation.JsLayoutRenderer: Super expression must either be null or 
a function TypeError: Super expression must either be null or a function at _inherits 
(C:\inetpub\wwwroot\dist\react\server.bundle.js:947:11) at C:\inetpub\wwwroot\dist\react\server.bundle.js:21541:171 at 
Module.
  • Resolves warnings presented in the console before
    Warnings

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team August 30, 2022 08:15
ambrauer
ambrauer approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thought, otherwise looks good to me

packages/create-sitecore-jss/src/common/processes/transform.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 3c0f5ff into dev Aug 31, 2022
@illiakovalenko illiakovalenko deleted the bugfix/546091 branch August 31, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer